From: Randy Dunlap <randy.dunlap@oracle.com>
To: lkml <linux-kernel@vger.kernel.org>, Jens Axboe <jens.axboe@oracle.com>
Subject: [PATCH] block: jiffies fixes
Date: Tue, 10 Nov 2009 16:22:42 -0800 [thread overview]
Message-ID: <4AFA03D2.6070701@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
Use HZ-independent calculation of milliseconds.
Add jiffies.h where it was missing since functions or macros
from it are used.
Oh, where has as-iosched.c in linux-next?
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
block/as-iosched.c | 3 ++-
block/blk-settings.c | 3 ++-
block/bsg.c | 3 ++-
block/cfq-iosched.c | 1 +
4 files changed, 7 insertions(+), 3 deletions(-)
--- lnx-2632-rc6.orig/block/blk-settings.c
+++ lnx-2632-rc6/block/blk-settings.c
@@ -8,6 +8,7 @@
#include <linux/blkdev.h>
#include <linux/bootmem.h> /* for max_pfn/max_low_pfn */
#include <linux/gcd.h>
+#include <linux/jiffies.h>
#include "blk.h"
@@ -141,7 +142,7 @@ void blk_queue_make_request(struct reque
q->nr_batching = BLK_BATCH_REQ;
q->unplug_thresh = 4; /* hmm */
- q->unplug_delay = (3 * HZ) / 1000; /* 3 milliseconds */
+ q->unplug_delay = msecs_to_jiffies(3); /* 3 milliseconds */
if (q->unplug_delay == 0)
q->unplug_delay = 1;
--- lnx-2632-rc6.orig/block/bsg.c
+++ lnx-2632-rc6/block/bsg.c
@@ -15,6 +15,7 @@
#include <linux/blkdev.h>
#include <linux/poll.h>
#include <linux/cdev.h>
+#include <linux/jiffies.h>
#include <linux/percpu.h>
#include <linux/uio.h>
#include <linux/idr.h>
@@ -197,7 +198,7 @@ static int blk_fill_sgv4_hdr_rq(struct r
rq->cmd_len = hdr->request_len;
rq->cmd_type = REQ_TYPE_BLOCK_PC;
- rq->timeout = (hdr->timeout * HZ) / 1000;
+ rq->timeout = msecs_to_jiffies(hdr->timeout);
if (!rq->timeout)
rq->timeout = q->sg_timeout;
if (!rq->timeout)
--- lnx-2632-rc6.orig/block/as-iosched.c
+++ lnx-2632-rc6/block/as-iosched.c
@@ -10,6 +10,7 @@
#include <linux/blkdev.h>
#include <linux/elevator.h>
#include <linux/bio.h>
+#include <linux/jiffies.h>
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/init.h>
@@ -600,7 +601,7 @@ static int as_close_req(struct as_data *
if (delay == 0)
delta = 8192;
- else if (delay <= (20 * HZ / 1000) && delay <= ad->antic_expire)
+ else if (delay <= msecs_to_jiffies(20) && delay <= ad->antic_expire)
delta = 8192 << delay;
else
return 1;
--- lnx-2632-rc6.orig/block/cfq-iosched.c
+++ lnx-2632-rc6/block/cfq-iosched.c
@@ -9,6 +9,7 @@
#include <linux/module.h>
#include <linux/blkdev.h>
#include <linux/elevator.h>
+#include <linux/jiffies.h>
#include <linux/rbtree.h>
#include <linux/ioprio.h>
#include <linux/blktrace_api.h>
next reply other threads:[~2009-11-11 0:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 0:22 Randy Dunlap [this message]
2009-11-11 16:08 ` [PATCH] block: jiffies fixes Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFA03D2.6070701@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox