* [PATCH] mISDN: fix error return in HFCmulti_init()
@ 2009-11-12 16:53 Roel Kluin
2009-11-13 12:17 ` Karsten Keil
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-11-12 16:53 UTC (permalink / raw)
To: Karsten Keil, isdn4linux, Andrew Morton, LKML
The returned error should stay negative
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/isdn/hardware/mISDN/hfcmulti.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c b/drivers/isdn/hardware/mISDN/hfcmulti.c
index faed794..a6624ad 100644
--- a/drivers/isdn/hardware/mISDN/hfcmulti.c
+++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
@@ -5481,7 +5481,7 @@ HFCmulti_init(void)
if (err) {
printk(KERN_ERR "error registering embedded driver: "
"%x\n", err);
- return -err;
+ return err;
}
HFC_cnt++;
printk(KERN_INFO "%d devices registered\n", HFC_cnt);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mISDN: fix error return in HFCmulti_init()
2009-11-12 16:53 [PATCH] mISDN: fix error return in HFCmulti_init() Roel Kluin
@ 2009-11-13 12:17 ` Karsten Keil
2009-11-16 5:18 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Karsten Keil @ 2009-11-13 12:17 UTC (permalink / raw)
To: Roel Kluin; +Cc: isdn4linux, Andrew Morton, LKML
On Donnerstag, 12. November 2009 17:53:25 Roel Kluin wrote:
The returned error should stay negative
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Karsten Keil <keil@b1-systems.de>
---
drivers/isdn/hardware/mISDN/hfcmulti.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c
b/drivers/isdn/hardware/mISDN/hfcmulti.c index faed794..a6624ad 100644
--- a/drivers/isdn/hardware/mISDN/hfcmulti.c
+++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
@@ -5481,7 +5481,7 @@ HFCmulti_init(void)
if (err) {
printk(KERN_ERR "error registering embedded driver: "
"%x\n", err);
- return -err;
+ return err;
}
HFC_cnt++;
printk(KERN_INFO "%d devices registered\n", HFC_cnt);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mISDN: fix error return in HFCmulti_init()
2009-11-13 12:17 ` Karsten Keil
@ 2009-11-16 5:18 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-11-16 5:18 UTC (permalink / raw)
To: keil; +Cc: roel.kluin, isdn4linux, akpm, linux-kernel
From: Karsten Keil <keil@b1-systems.de>
Date: Fri, 13 Nov 2009 13:17:10 +0100
> On Donnerstag, 12. November 2009 17:53:25 Roel Kluin wrote:
> The returned error should stay negative
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> Acked-by: Karsten Keil <keil@b1-systems.de>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-16 5:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-12 16:53 [PATCH] mISDN: fix error return in HFCmulti_init() Roel Kluin
2009-11-13 12:17 ` Karsten Keil
2009-11-16 5:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox