From: Yinghai Lu <yinghai@kernel.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Len Brown <lenb@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] x86: make sure wakeup code is below 1M -v2
Date: Thu, 12 Nov 2009 11:25:49 -0800 [thread overview]
Message-ID: <4AFC613D.2060808@kernel.org> (raw)
In-Reply-To: <20091112073616.GA11365@elf.ucw.cz>
Pavel Machek wrote:
> On Tue 2009-11-10 18:27:23, Yinghai Lu wrote:
>> try to find_e820_area/reserve_early, and call acpi_reserve_memory early
>>
>> to get area is below 1M
>
>> - acpi_realmode = (unsigned long)alloc_bootmem_low(WAKEUP_SIZE);
>> + mem = find_e820_area(0, 1<<20, WAKEUP_SIZE, PAGE_SIZE);
>>
>> - if (!acpi_realmode) {
>> + if (mem == -1L) {
>> printk(KERN_ERR "ACPI: Cannot allocate lowmem, S3 disabled.\n");
>> return;
>> }
>
> How is it better then old code?
could get range below 1M.
alloc_bootmem_low can not make sure get that below 1M.
init_memory_mapping could use below 1M as page table...
so need to get some buffer for acpi wakeup realmode code.
YH
next prev parent reply other threads:[~2009-11-12 19:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 8:51 [RFC PATCH] x86: make sure wakeup code is below 1M Yinghai Lu
2009-11-09 12:15 ` Rafael J. Wysocki
2009-11-11 2:27 ` [PATCH] x86: make sure wakeup code is below 1M -v2 Yinghai Lu
2009-11-11 7:48 ` Ingo Molnar
2009-11-11 7:57 ` H. Peter Anvin
2009-11-11 9:56 ` Rafael J. Wysocki
2009-11-11 9:12 ` ykzhao
2009-11-11 19:05 ` Yinghai Lu
2009-11-12 1:17 ` ykzhao
2009-11-12 3:12 ` Yinghai Lu
2009-11-12 3:37 ` ykzhao
2009-11-12 5:21 ` Yinghai Lu
2009-11-12 7:14 ` ykzhao
2009-11-12 7:20 ` H. Peter Anvin
2009-11-12 7:43 ` ykzhao
2009-11-11 20:30 ` [tip:x86/mm] x86: Make sure wakeup trampoline code is below 1MB tip-bot for Yinghai Lu
2009-11-12 7:36 ` [PATCH] x86: make sure wakeup code is below 1M -v2 Pavel Machek
2009-11-12 19:25 ` Yinghai Lu [this message]
2009-11-12 19:32 ` Rafael J. Wysocki
2009-11-13 7:36 ` Ingo Molnar
2009-11-13 8:04 ` H. Peter Anvin
2009-11-13 8:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFC613D.2060808@kernel.org \
--to=yinghai@kernel.org \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox