From: Yinghai Lu <yinghai@kernel.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
x86team <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86,io-apic: Do not map IO-APIC direct registers twice
Date: Fri, 13 Nov 2009 11:23:36 -0800 [thread overview]
Message-ID: <4AFDB238.5050903@kernel.org> (raw)
In-Reply-To: <20091113192242.GD5695@lenovo>
Cyrill Gorcunov wrote:
> On Fri, Nov 13, 2009 at 11:17:00AM -0800, Yinghai Lu wrote:
>>>> Cyrill Gorcunov wrote:
>>>>> On Thu, Nov 12, 2009 at 03:22:55PM -0800, Yinghai Lu wrote:
>>>> 2. print out ...?
>>> Print out what? Not sure I understand you right. Perhaps you mean
>>> to check insert_resourse results?
> ...
>> apic_printk(APIC_VERBOSE,
>> "mapped IOAPIC to %08lx (%08lx)\n",
>> - __fix_to_virt(idx), ioapic_phys);
>> + __fix_to_virt(idx) + (ioapic_phys & ~PAGE_MASK),
>>
>> YH
>>
>
> Updated version below, thanks Yinghai! Looks good?
good to me.
YH
prev parent reply other threads:[~2009-11-13 19:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 20:48 [RFC -tip] x86,io-apic: Do not map IO-APIC direct registers twice Cyrill Gorcunov
2009-11-12 20:54 ` Cyrill Gorcunov
2009-11-12 21:06 ` Cyrill Gorcunov
2009-11-12 23:22 ` Yinghai Lu
2009-11-13 17:50 ` Cyrill Gorcunov
2009-11-13 18:56 ` Yinghai Lu
2009-11-13 19:09 ` Cyrill Gorcunov
2009-11-13 19:17 ` Yinghai Lu
2009-11-13 19:22 ` Cyrill Gorcunov
2009-11-13 19:23 ` Yinghai Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFDB238.5050903@kernel.org \
--to=yinghai@kernel.org \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox