From: "H. Peter Anvin" <hpa@zytor.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-kernel@vger.kernel.org, gregkh@suse.de
Subject: Re: [PATCH 2/3] vc: Add support for hiding the cursor when creating VTs
Date: Fri, 13 Nov 2009 14:38:43 -0800 [thread overview]
Message-ID: <4AFDDFF3.2070601@zytor.com> (raw)
In-Reply-To: <1258142222-16092-2-git-send-email-mjg@redhat.com>
On 11/13/2009 11:57 AM, Matthew Garrett wrote:
>
> static int con_open(struct tty_struct *, struct file *);
> static void vc_init(struct vc_data *vc, unsigned int rows,
> - unsigned int cols, int do_clear);
> + unsigned int cols, int do_clear)
Uhm... this doesn't compile.
I'm going to bounce this patch, not because I can't just add the
semicolon back and recompile it, but because that means you never
compiled it and therefore never tested it.
Please fix, test, and resubmit.
-hpa
next prev parent reply other threads:[~2009-11-13 22:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 19:57 [PATCH 1/3] setup: Store the boot cursor state Matthew Garrett
2009-11-13 19:57 ` [PATCH 2/3] vc: Add support for hiding the cursor when creating VTs Matthew Garrett
2009-11-13 19:57 ` [PATCH 3/3] vgacon: Add support for setting the default cursor state Matthew Garrett
2009-11-14 0:10 ` [tip:x86/setup] " tip-bot for Matthew Garrett
2009-11-13 20:14 ` [PATCH v2] vc: Add support for hiding the cursor when creating VTs Matthew Garrett
2009-11-14 0:09 ` [tip:x86/setup] " tip-bot for Matthew Garrett
2009-11-13 22:38 ` H. Peter Anvin [this message]
2009-11-13 22:41 ` [PATCH 2/3] " Matthew Garrett
2009-11-13 21:51 ` [PATCH 1/3] setup: Store the boot cursor state H. Peter Anvin
2009-11-13 22:02 ` Matthew Garrett
2009-11-13 22:16 ` H. Peter Anvin
2009-11-14 0:09 ` [tip:x86/setup] x86, " tip-bot for Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AFDDFF3.2070601@zytor.com \
--to=hpa@zytor.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox