From: "Éric Piel" <eric.piel@tremplin-utc.net>
To: Samu Onkalo <samu.p.onkalo@nokia.com>
Cc: daniel@caiaq.de, pavel@ucw.cz, linux-kernel@vger.kernel.org,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH v2 02/10] LIS3LV02D: Correct memory leak in module unload
Date: Sun, 15 Nov 2009 16:49:33 +0100 [thread overview]
Message-ID: <4B00230D.3090808@tremplin-utc.net> (raw)
In-Reply-To: <1257856872-11612-3-git-send-email-samu.p.onkalo@nokia.com>
Op 10-11-09 13:41, Samu Onkalo schreef:
> polled input device itself was not free'd.
>
> Signed-off-by: Samu Onkalo <samu.p.onkalo@nokia.com>
Acked-by: Éric Piel <eric.piel@tremplin-utc.net>
> ---
> drivers/hwmon/lis3lv02d.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hwmon/lis3lv02d.c b/drivers/hwmon/lis3lv02d.c
> index 7f43a3b..dbd0b05 100644
> --- a/drivers/hwmon/lis3lv02d.c
> +++ b/drivers/hwmon/lis3lv02d.c
> @@ -333,6 +333,7 @@ void lis3lv02d_joystick_disable(void)
> if (lis3_dev.irq)
> misc_deregister(&lis3lv02d_misc_device);
> input_unregister_polled_device(lis3_dev.idev);
> + input_free_polled_device(lis3_dev.idev);
> lis3_dev.idev = NULL;
> }
> EXPORT_SYMBOL_GPL(lis3lv02d_joystick_disable);
next prev parent reply other threads:[~2009-11-15 15:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 12:41 [PATCH v2 00/10] LIS3: Feature updates and corrections Samu Onkalo
2009-11-10 12:41 ` [PATCH v2 01/10] LIS3LV02D: Send sync event Samu Onkalo
2009-11-10 12:41 ` [PATCH v2 02/10] LIS3LV02D: Correct memory leak in module unload Samu Onkalo
2009-11-10 12:41 ` [PATCH v2 03/10] lis3: Update documentation and comments Samu Onkalo
2009-11-10 12:41 ` [PATCH v2 04/10] lis3: fix show rate for 8 bits chips Samu Onkalo
2009-11-10 12:41 ` [PATCH v2 05/10] LIS3LV02D: Proper power on sequence Samu Onkalo
2009-11-10 12:41 ` [PATCH v2 06/10] LIS3LV02D: Selftest support Samu Onkalo
2009-11-10 12:41 ` [PATCH v2 07/10] LIS3LV02D: Remove calibaration functionality Samu Onkalo
2009-11-10 12:41 ` [PATCH v2 08/10] lis3: Sysfs entry for setting chip measurement rate Samu Onkalo
2009-11-10 12:41 ` [PATCH v2 09/10] lis3: Scale output values to mg Samu Onkalo
2009-11-10 12:41 ` [PATCH v2 10/10] LIS3: Update documentation to match latest changes Samu Onkalo
2009-11-15 15:43 ` Éric Piel
2009-11-15 15:32 ` [PATCH v2 09/10] lis3: Scale output values to mg Éric Piel
2009-11-15 18:04 ` Pavel Machek
2009-11-15 15:20 ` [PATCH v2 08/10] lis3: Sysfs entry for setting chip measurement rate Éric Piel
2009-11-15 15:54 ` [PATCH v2 07/10] LIS3LV02D: Remove calibaration functionality Éric Piel
2009-11-15 15:08 ` [PATCH v2 06/10] LIS3LV02D: Selftest support Éric Piel
2009-11-15 15:54 ` [PATCH v2 05/10] LIS3LV02D: Proper power on sequence Éric Piel
2009-11-15 15:53 ` [PATCH v2 04/10] lis3: fix show rate for 8 bits chips Éric Piel
2009-11-15 15:49 ` Éric Piel [this message]
2009-11-15 15:49 ` [PATCH v2 01/10] LIS3LV02D: Send sync event Éric Piel
2009-11-15 16:01 ` [PATCH v2 00/10] LIS3: Feature updates and corrections Éric Piel
2009-11-16 20:03 ` Andrew Morton
2009-11-16 20:37 ` Éric Piel
2009-11-17 6:04 ` samu.p.onkalo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B00230D.3090808@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=daniel@caiaq.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=pavel@ucw.cz \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox