From: Prarit Bhargava <prarit@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, bhavna.sarathy@amd.com,
jbarnes@virtuousgeek.org, andreas.herrmann3@amd.com
Subject: Re: [PATCH]: AMD Northbridge: Verify NB's node is online
Date: Mon, 16 Nov 2009 08:39:38 -0500 [thread overview]
Message-ID: <4B01561A.4090109@redhat.com> (raw)
In-Reply-To: <20091114005800.GB17512@elte.hu>
>>
>> Hardware maybe programmed incorrectly and return a bogus node ID.
>> Check to see if the node is actually online before setting the numa
>> node for an AMD northbridge in quirk_amd_nb_node().
>>
>
> Hm, could you stick a printk in there, what precise node ID does the
> hardware return?
>
>
Ingo, yup -- I put in a printk and commented out the set_dev_node() call
when debugging this
and got this output:
quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x0
quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x1
quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x2
quirk_amd_nb_node: current numa_node = 0x0, would set to val & 7 = 0x3
The issue appears to be that the HW has set val to a valid value,
however, the system is only configured for a single node -- 0.
I realize that I'm working around broken HW ... but I think that a
quirk, quirk_amd_nb_node(), should at least keep systems booting ...
P.
next prev parent reply other threads:[~2009-11-16 13:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 18:09 [PATCH]: AMD Northbridge: Verify NB's node is online Prarit Bhargava
2009-11-14 0:58 ` Ingo Molnar
2009-11-16 13:39 ` Prarit Bhargava [this message]
2009-11-16 14:44 ` Ingo Molnar
2009-11-16 16:10 ` [tip:x86/urgent] x86: " tip-bot for Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B01561A.4090109@redhat.com \
--to=prarit@redhat.com \
--cc=andreas.herrmann3@amd.com \
--cc=bhavna.sarathy@amd.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox