Re: [PATCH 3/6] INIT: Limit the number of per cpu calibration bootup messages

Cyrill Gorcunov
2009-11-16T21:43:08Z

On Mon, Nov 16, 2009 at 01:27:55PM -0800, H. Peter Anvin wrote:
> On 11/16/2009 01:24 PM, Ingo Molnar wrote:
> >
> > * Mike Travis <travis@sgi.com> wrote:
> >
> >> --- linux.orig/init/calibrate.c
> >> +++ linux/init/calibrate.c
> >> @@ -123,23 +123,26 @@
> >> {
> >> unsigned long ticks, loopbit;
> >> int lps_precision = LPS_PREC;
> >> + bool boot_cpu = (smp_processor_id() == 0);
> >
> > this code is shared by other architectures too - are you sure
> > smp_processor_id()==0 is a proper 'I am the boot CPU' assumption
> > everywhere?
> >
>
> It really shouldn't be for x86 either, although right now we play nasty
> renumbering games to accommodate that assumption. It seems like we
> really should have a boot_cpu_id() or some such.
>
> -hpa
>

It seems we have one

arch/x86/kernel/setup.c:125:unsigned int boot_cpu_id __read_mostly;

-- Cyrill