Re: [PATCH 3/6] INIT: Limit the number of per cpu calibration bootup messages

Cyrill Gorcunov
2009-11-17T17:59:57Z

On Tue, Nov 17, 2009 at 09:49:54AM -0800, Mike Travis wrote:
...
>>> And if we do need it generically, it's available there as
>>> hard_smp_processor_id() when start_kernel() is called. So init/main.c
>>> could remember that value in an __initdata annotated static variable.
>>>
>>> But just using a boolean for this "did I print the bogomips message
>>> already?" thing seems more than sufficient.
>>>
>>
>> Yes. As I see Mike already pick it up. Thanks David!
>>
>> -- Cyrill
>
> I'd like to say that, but Peter wanted it to become an inlined function
> return value, and there are too many references in too many arches to
> a scalar value, so that moves it out of the scope of this patch set.

I meant only "local static variable being used for printing to suppress recursion"
idea rather then boot_cpu_id() inliner at moment [btw there was some thread
someday about printk_once (or something like that) though I'm not sure if patches
were merged] :) As only the inliner will be ready we will just switch to use it
eliminating this static variable. That is how I imagine it.

> Thanks,
> Mike
>
-- Cyrill