Re: [PATCH 3/3] macvlan: export macvlan mode through netlink

Arnd Bergmann
2009-11-18T09:59:52Z

On Wednesday 18 November 2009, Eric Dumazet wrote:
> > --- a/drivers/net/macvlan.c
> > +++ b/drivers/net/macvlan.c
> > @@ -33,12 +33,6 @@
> >
> > #define MACVLAN_HASH_SIZE (1 << BITS_PER_BYTE)
> >
> > -enum macvlan_type {
> > - MACVLAN_PRIVATE = 1,
> > - MACVLAN_VEPA = 2,
> > - MACVLAN_BRIDGE = 4,
> > -};
>
> I realize you defined MACVLAN_PRIVATE in patch 2, but used MACVLAN_MODE_PRIVATE,
> so patch 2 is not compilable and breaks bisection ?
>

Hmm, right. I'll fix that up as well.

Thanks,