From: Juha Keski-Saari <ext-juha.1.keski-saari@nokia.com>
To: ext Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Valentin Eduardo (Nokia-D/Helsinki)"
<eduardo.valentin@nokia.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"dbrownell@users.sourceforge.net"
<dbrownell@users.sourceforge.net>,
"tony@atomide.com" <tony@atomide.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>,
"Hunter Adrian (Nokia-D/Helsinki)" <adrian.hunter@nokia.com>,
"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
"dtor@mail.ru" <dtor@mail.ru>,
"De-Schrijver Peter (Nokia-D/Helsinki)"
<Peter.De-Schrijver@nokia.com>,
"Kristo Tero (Nokia-D/Tampere)" <Tero.Kristo@nokia.com>
Subject: Re: [PATCH 1/1] Add all TWL4030 regulators to Regulator framework
Date: Thu, 19 Nov 2009 09:04:08 +0200 [thread overview]
Message-ID: <4B04EDE8.1010906@nokia.com> (raw)
In-Reply-To: <20091118144145.GA16852@rakim.wolfsonmicro.main>
ext Mark Brown wrote:
> On Wed, Nov 18, 2009 at 04:36:09PM +0200, Eduardo Valentin wrote:
>
>> But maybe these VINT* should be set as always_on in twl4030-regulator driver?
>
> Can they support any external load at all? If not then it would make
> sense for the chip driver to at least provide a default set of
> constraints for them rather than forcing all the machine drivers to do
> it manually.
From the TRM it appears that the max current output values are as follows
VINTANA1 - 30mA
VINTANA2 - 250mA
VINTDIG - 100mA
Theoretically they may be able to support external load depending on your machine configuration but still I think providing constraints for them in
the chip driver could be a good idea since the "always-on" limitation is imposed by the chip and not the machine. Without these three supplies the TWL
does not function properly, if at all. Also worth noting is that the current implementation of RegulatorFW doesn't appear to be able to turn these
supplies off (comparing TWL register content with framework status).
next prev parent reply other threads:[~2009-11-19 7:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 11:45 [PATCH 0/1] Add all TWL4030 regulators to Regulator framework Juha Keski-Saari
2009-11-18 11:46 ` [PATCH 1/1] " Juha Keski-Saari
2009-11-18 13:39 ` Mark Brown
2009-11-18 14:36 ` Eduardo Valentin
2009-11-18 14:41 ` Mark Brown
2009-11-19 7:04 ` Juha Keski-Saari [this message]
2009-11-19 9:24 ` Peter 'p2' De Schrijver
2009-11-19 10:30 ` Mark Brown
2009-11-20 10:06 ` Samuel Ortiz
2009-11-20 10:32 ` Liam Girdwood
2009-11-20 11:28 ` Mark Brown
2009-11-20 12:21 ` Liam Girdwood
2009-11-20 12:36 ` Mark Brown
2009-11-23 13:26 ` Juha Keski-Saari
2009-11-18 17:51 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B04EDE8.1010906@nokia.com \
--to=ext-juha.1.keski-saari@nokia.com \
--cc=Peter.De-Schrijver@nokia.com \
--cc=Tero.Kristo@nokia.com \
--cc=adrian.hunter@nokia.com \
--cc=amit.kucheria@verdurent.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dbrownell@users.sourceforge.net \
--cc=dtor@mail.ru \
--cc=eduardo.valentin@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox