From: Avi Kivity <avi@redhat.com>
To: Adam Litke <agl@us.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: virtio: Add memory statistics reporting to the balloon driver (V3)
Date: Thu, 19 Nov 2009 18:13:44 +0200 [thread overview]
Message-ID: <4B056EB8.9020509@redhat.com> (raw)
In-Reply-To: <1258646331.3464.18.camel@aglitke>
On 11/19/2009 05:58 PM, Adam Litke wrote:
> On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote:
>
>> On 11/19/2009 05:19 PM, Adam Litke wrote:
>>
>>> Rusty and Anthony,
>>> If I've addressed all outstanding issues, please consider this patch for
>>> inclusion. Thanks.
>>>
>>> +struct virtio_balloon_stat
>>> +{
>>> + __le16 tag;
>>> + __le64 val;
>>> +};
>>> +
>>>
>>>
>> You're not doing endian conversion in the host?
>>
> No. I was following by example. For the virtio_balloon, the existing
> code is careful so that the guest always writes data in little endian.
>
I don't follow. If the guest is careful to write little-endian, surely
the host must be equally careful to read little-endian?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-11-19 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1258643169.3464.3.camel@aglitke>
2009-11-19 15:19 ` virtio: Add memory statistics reporting to the balloon driver (V3) Adam Litke
2009-11-19 15:22 ` Avi Kivity
2009-11-19 15:58 ` Adam Litke
2009-11-19 16:13 ` Avi Kivity [this message]
2009-11-19 16:29 ` Adam Litke
2009-11-19 23:53 ` Rusty Russell
2009-11-23 9:44 ` Michael S. Tsirkin
2009-11-23 11:00 ` [Qemu-devel] " Dor Laor
2009-11-23 11:31 ` Vadim Rozenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B056EB8.9020509@redhat.com \
--to=avi@redhat.com \
--cc=agl@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox