public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frank Rowand <frank.rowand@am.sony.com>
To: peterz@infradead.org, mingo@redhat.com
Cc: tom.leiming@gmail.com, linux-kernel@vger.kernel.org
Subject: [PATCH] LOCKSTAT: patch test - Fix min, max times in /proc/lock_stats
Date: Thu, 19 Nov 2009 13:42:06 -0800	[thread overview]
Message-ID: <4B05BBAE.2050005@am.sony.com> (raw)

Fix min, max times in /proc/lock_stats

(1) When collecting lock hold and wait times, if the current minimum time is
    zero, it will be replaced by the next time.

(2) When aggregating minimum and maximum lock hold and wait times accross cpus,
    the values are added, instead of selecting the minimum and maximum.


Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>

---
 kernel/lockdep.c |   11 	9 +	2 -	0 !
 1 files changed, 9 insertions(+), 2 deletions(-)

Index: linux-2.6/kernel/lockdep.c
===================================================================
--- linux-2.6.orig/kernel/lockdep.c
+++ linux-2.6/kernel/lockdep.c
@@ -168,7 +168,7 @@ static void lock_time_inc(struct lock_ti
 	if (time > lt->max)
 		lt->max = time;
 
-	if (time < lt->min || !lt->min)
+	if (time < lt->min || !lt->nr)
 		lt->min = time;
 
 	lt->total += time;
@@ -177,8 +177,15 @@ static void lock_time_inc(struct lock_ti
 
 static inline void lock_time_add(struct lock_time *src, struct lock_time *dst)
 {
-	dst->min += src->min;
-	dst->max += src->max;
+	if (!src->nr)
+		return;
+
+	if (src->max > dst->max)
+		dst->max = src->max;
+
+	if (src->min < dst->min || !dst->nr)
+		dst->min = src->min;
+
 	dst->total += src->total;
 	dst->nr += src->nr;
 }


             reply	other threads:[~2009-11-19 21:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19 21:42 Frank Rowand [this message]
2009-11-19 22:29 ` [PATCH] LOCKSTAT: patch test - Fix min, max times in /proc/lock_stats Peter Zijlstra
2009-12-06 13:03 ` [tip:core/urgent] lockstat: " tip-bot for Frank Rowand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B05BBAE.2050005@am.sony.com \
    --to=frank.rowand@am.sony.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox