Re: [PATCH 5/5] pata_piccolo: Driver for old Toshiba chipsets

Alan Cox
2009-11-27T15:32:30Z

> > +#define PCI_DEVICE_ID_TOSHIBA_PICCOLO 0x0101
> > +#define PCI_DEVICE_ID_TOSHIBA_PICCOLO_2 0x0102
> > +#define PCI_DEVICE_ID_TOSHIBA_PICCOLO_3 0x0103
> > +#define PCI_DEVICE_ID_TOSHIBA_PICCOLO_5 0x0105
> > #define PCI_DEVICE_ID_TOSHIBA_TOPIC95 0x060a
> > #define PCI_DEVICE_ID_TOSHIBA_TOPIC97 0x060f
> > #define PCI_DEVICE_ID_TOSHIBA_TOPIC100 0x0617
>
> This adds kernel regression and breaks kernel build (it is generally good to
> grep kernel tree for the existing users before doing changes like the above):
>
> drivers/ide/ide-pci-generic.c:
>
> { PCI_VDEVICE(TOSHIBA, PCI_DEVICE_ID_TOSHIBA_PICCOLO), 4 },
> { PCI_VDEVICE(TOSHIBA, PCI_DEVICE_ID_TOSHIBA_PICCOLO_1), 4 },
> { PCI_VDEVICE(TOSHIBA, PCI_DEVICE_ID_TOSHIBA_PICCOLO_2), 4 },
>
> Please fix your patch.

Will do - I'll add the missing ones to ide-generic as well.

Alan