Re: [PATCH 4/5] pata: Update experimental tags

Bartlomiej Zolnierkiewicz
2009-11-18T19:57:29Z

On Wednesday 18 November 2009 20:07:07 Bartlomiej Zolnierkiewicz wrote:
> On Wednesday 18 November 2009 19:41:25 Alan Cox wrote:
> > > Maybe they are 'stable' but when it comes to features they are behind hpt366
> > > (i.e. they lack PCI PM), which is also much cleaner than your drivers, easier
> > > to understand and much smaller..
> >
> > 37x and 3xn lack PCI PM. Added to the TODO list.
> >
> > The smaller size is a bit questionable given its mostly comments, and
> > three drivers versus one.
>
> I wonder what you find 'questionable' in the numbers given..

BTW we can immediately reclaim 300 LOC by simply merging drivers back..

> > themselves don't keep common. Even more importantly we get to break *one*
> > type of device at a time.
>
> I prefer to not break anything, but hey my way of doing things is not
> very much welcomed here..
>
> I also like to think that by sharing code we get better testing coverage
> and are in reality able to fix problems much faster because of this..

Wait, you seem to be right!

Only pata_hpt37x has broken cable detection while pata_hpt3x2n is okay. ;)

--
Bartlomiej Zolnierkiewicz