From: Li Zefan <lizf@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mathieu Desnoyers <compudj@krystal.dyndns.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/4] [PATCH 2/4] tracing: Create new TRACE_EVENT_TEMPLATE
Date: Fri, 20 Nov 2009 16:06:45 +0800 [thread overview]
Message-ID: <4B064E15.9010708@cn.fujitsu.com> (raw)
In-Reply-To: <20091119171106.611553083@goodmis.org>
Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@redhat.com>
>
> There are some places in the kernel that define several tracepoints and
> they are all identical besides the name. The code to enable, disable and
> record is created for every trace point even if most of the code is
> identical.
>
> This patch adds TRACE_EVENT_TEMPLATE that lets the developer create
> a template TRACE_EVENT and create trace points with DEFINE_EVENT, which
> is based off of a given template. Each trace point used by this
> will share most of the code, and bring down the size of the kernel
> when there are several duplicate events.
>
Great!
There are quite many places that this template can be used.
If you haven't planed to convert other TRACE_EVENTs, I'll take it.
More over, I'll cook another patch to annotate some functions as
__init, so shrink the kernel size further.
next prev parent reply other threads:[~2009-11-20 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 17:10 [PATCH 0/4] [GIT PULL] tracing: Fix and trace event space savings Steven Rostedt
2009-11-19 17:10 ` [PATCH 1/4] [PATCH 1/4] tracing: Fix strstrip usage in set_ftrace_pid Steven Rostedt
2009-11-19 17:10 ` [PATCH 2/4] [PATCH 2/4] tracing: Create new TRACE_EVENT_TEMPLATE Steven Rostedt
2009-11-20 8:06 ` Li Zefan [this message]
2009-11-19 17:10 ` [PATCH 3/4] [PATCH 3/4] tracing: Create new DEFINE_EVENT_PRINT Steven Rostedt
2009-11-19 17:10 ` [PATCH 4/4] [PATCH 4/4] tracing: Convert some sched trace events to DEFINE_EVENT and _PRINT Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B064E15.9010708@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=compudj@krystal.dyndns.org \
--cc=fweisbec@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox