Re: [PATCH] k10temp: temperature sensor for AMD Family 10h/11h CPUs

Serge Belyshev
2009-11-20T10:52:55Z

> +All these processors have a sensor, but on older revisions of Family 10h
> +processors, the sensor returns inconsistent values (erratum 319). The driver
> +refuses to load with these revisions (DR-BA, DR-B2, DR-B3: some Embedded
> +Opterons on Socket F; and Quad-Core Opteron, Phenom Triple/Quad-Core, and
> +Athon Dual-Core on Socket AM2+). All later revisions (RB-C2, BL-C2, DA-C2,
> +RB-C3, HY-D0) work fine; see the list above.

Please note that erratum actually states that the sensor only "may report
inconsistent values.", not that it is always broken. As evident by my
own experience (tested with a userspace application), it actually works
perfectly on all B3 stepping processors that I have.

> +static bool __devinit has_erratum_319(void)
> +{
> + /*
> + * Erratum 319: The thermal sensor of older Family 10h processors
> + * (B steppings) is unreliable.
> + */
> + return boot_cpu_data.x86 == 0x10 && boot_cpu_data.x86_model <= 2;
> +}
...
> + if (has_erratum_319()) {
> + dev_err(&pdev->dev,
> + "unreliable CPU thermal sensor; monitoring disabled\n");
> + err = -ENODEV;
> + goto exit;
> + }

So, please provide an alternative for those who have a working sensor on a
revision B processor and want to use it.