public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: benh@kernel.crashing.org, dmitchell@amcc.com
Cc: Grant Likely <grant.likely@secretlab.ca>,
	John Williams <john.williams@petalogix.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Add UPF_FIXED_TYPE flag - eedacbf02df462d6c915d8d642b23fb450d485c7
Date: Mon, 23 Nov 2009 17:53:21 +0100	[thread overview]
Message-ID: <4B0ABE01.3030901@monstr.eu> (raw)

Hi Ben and David,

I have found one problem with input overrun. My problem is of course on 
Microblaze with uart16550.

Here is the behavior - I just pressed left arrow.

~ # fdasfdakjsdhfkajsdhfkjadklasdjfhajksdhfkahsdfjkahsdkjfhjkattyS0: 3 
input overrun(s)
[[DttyS0: 3 input overrun(s)
[[[[[DDDahsdk[[[[D[DDjfhjka[D          [[[DttyS0: 6 input 
overrun(s)jk[[D[D[[D[[
[[[[D[Dsd[[Dhfkah[[[[DD[[DDsdfjk[[D[D[[[[D[[[D[Dsd[[Dhfkah[[[[DD[[DDsdfjk[[D[D[[
D[[[[DDDahsdk[[[[D[DDjfhjka[D
-sh: 
fdasfdakjsdhfkajsdhfkjadklasdjfhajk[[D[[[D[Dsd[[Dhfkah[[[[DD[[DDsdfjk[[D[D[[D[[[[DDDahsdk[[[[D[DDjfhjka[D: 
not found


I bisected it and yours Subject patch caused my problems. It is really 
old patch and I was surprised how old it is.


Here is your diff
diff --git a/drivers/serial/of_serial.c b/drivers/serial/of_serial.c
index 02406ba..54483cd 100644
--- a/drivers/serial/of_serial.c
+++ b/drivers/serial/of_serial.c
@@ -67,7 +67,7 @@ static int __devinit of_platform_serial_setup(struct 
of_device *ofdev,
         port->type = type;
         port->uartclk = *clk;
         port->flags = UPF_SHARE_IRQ | UPF_BOOT_AUTOCONF | UPF_IOREMAP
-               | UPF_FIXED_PORT | UPF_FIXED_TYPE;
+               | UPF_FIXED_PORT;
         port->dev = &ofdev->dev;
         /* If current-speed was set, then try not to change it. */
         if (spd)


If I trace port->type I am getting 3. (drivers/serial/8250.c:3089 
serial8250_register_port func 3118 - serial8250_register_port)
Grant: Could you please print that value on ppc?

Can you give me any hints what could be wrong? I will continue on it 
tomorrow.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

             reply	other threads:[~2009-11-23 16:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23 16:53 Michal Simek [this message]
2009-11-24  9:07 ` Add UPF_FIXED_TYPE flag - eedacbf02df462d6c915d8d642b23fb450d485c7 Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0ABE01.3030901@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=benh@kernel.crashing.org \
    --cc=dmitchell@amcc.com \
    --cc=grant.likely@secretlab.ca \
    --cc=john.williams@petalogix.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox