From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755959AbZKWTld (ORCPT ); Mon, 23 Nov 2009 14:41:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755570AbZKWTlc (ORCPT ); Mon, 23 Nov 2009 14:41:32 -0500 Received: from gateway-1237.mvista.com ([206.112.117.35]:6728 "HELO imap.sh.mvista.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1755098AbZKWTlc (ORCPT ); Mon, 23 Nov 2009 14:41:32 -0500 Message-ID: <4B0AE59F.7040202@ru.mvista.com> Date: Mon, 23 Nov 2009 22:42:23 +0300 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz Cc: Jeff Garzik , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] pata_hpt37x: add proper cable detection methods References: <200911191910.44609.bzolnier@gmail.com> In-Reply-To: <200911191910.44609.bzolnier@gmail.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. Bartlomiej Zolnierkiewicz wrote: > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/ata/pata_hpt37x.c | 86 +++++++++++++++++++++++++++++----------------- > 1 file changed, 56 insertions(+), 30 deletions(-) > Index: b/drivers/ata/pata_hpt37x.c > =================================================================== > --- a/drivers/ata/pata_hpt37x.c > +++ b/drivers/ata/pata_hpt37x.c > @@ -303,6 +303,59 @@ static unsigned long hpt370a_filter(stru As this driver still carries a version info, don't we need to update it? MBR, Sergei