* [PATCH] sysfs: fix SYSFS_DEPRECATED_V2 prompt
@ 2009-11-23 23:56 Randy Dunlap
2009-12-03 8:03 ` Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2009-11-23 23:56 UTC (permalink / raw)
To: LKML; +Cc: Greg KH, kay.sievers, Andrew Morton
From: Randy Dunlap <randy.dunlap@oracle.com>
The SYSFS_DEPRECATED_V2 says "remove" older, deprecated features,
but it actually enables them, so correct this confusing, backwards
text.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
---
init/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-2632-rc8.orig/init/Kconfig
+++ lnx-2632-rc8/init/Kconfig
@@ -606,7 +606,7 @@ config SYSFS_DEPRECATED
bool
config SYSFS_DEPRECATED_V2
- bool "remove sysfs features which may confuse old userspace tools"
+ bool "enable deprecated sysfs features which may confuse old userspace tools"
depends on SYSFS
default n
select SYSFS_DEPRECATED
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sysfs: fix SYSFS_DEPRECATED_V2 prompt
2009-11-23 23:56 [PATCH] sysfs: fix SYSFS_DEPRECATED_V2 prompt Randy Dunlap
@ 2009-12-03 8:03 ` Uwe Kleine-König
2009-12-03 16:31 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2009-12-03 8:03 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, Greg KH, kay.sievers, Andrew Morton, Linus Torvalds
Hello,
> config SYSFS_DEPRECATED_V2
> - bool "remove sysfs features which may confuse old userspace tools"
> + bool "enable deprecated sysfs features which may confuse old userspace tools"
Is this better? SYSFS_DEPRECATED_V2 enables deprecated sysfs features,
but this is done to *not* confuse old userspace tools, isn't it?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sysfs: fix SYSFS_DEPRECATED_V2 prompt
2009-12-03 8:03 ` Uwe Kleine-König
@ 2009-12-03 16:31 ` Randy Dunlap
2009-12-03 18:58 ` [PATCH] sysfs: deprecated features are to help old tools not to confuse them Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2009-12-03 16:31 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: LKML, Greg KH, kay.sievers, Andrew Morton, Linus Torvalds
On Thu, 3 Dec 2009 09:03:41 +0100 Uwe Kleine-König wrote:
> Hello,
>
> > config SYSFS_DEPRECATED_V2
> > - bool "remove sysfs features which may confuse old userspace tools"
> > + bool "enable deprecated sysfs features which may confuse old userspace tools"
> Is this better? SYSFS_DEPRECATED_V2 enables deprecated sysfs features,
> but this is done to *not* confuse old userspace tools, isn't it?
Hm, agreed that it is still a bit ambiguous.
Feel free to send (another) patch.
thanks,
---
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] sysfs: deprecated features are to help old tools not to confuse them
2009-12-03 16:31 ` Randy Dunlap
@ 2009-12-03 18:58 ` Uwe Kleine-König
2009-12-03 19:31 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2009-12-03 18:58 UTC (permalink / raw)
To: linux-kernel
Cc: trivial, Greg KH, Andrew Morton, Kay Sievers, Randy Dunlap,
Linus Torvalds
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Greg KH <gregkh@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
---
init/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/init/Kconfig b/init/Kconfig
index eb4b337..d7ac66b 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -606,7 +606,7 @@ config SYSFS_DEPRECATED
bool
config SYSFS_DEPRECATED_V2
- bool "enable deprecated sysfs features which may confuse old userspace tools"
+ bool "enable deprecated sysfs features to support old userspace tools"
depends on SYSFS
default n
select SYSFS_DEPRECATED
--
1.6.5.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] sysfs: deprecated features are to help old tools not to confuse them
2009-12-03 18:58 ` [PATCH] sysfs: deprecated features are to help old tools not to confuse them Uwe Kleine-König
@ 2009-12-03 19:31 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2009-12-03 19:31 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-kernel, trivial, Greg KH, Andrew Morton, Kay Sievers,
Linus Torvalds
On Thu, 3 Dec 2009 19:58:00 +0100 Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Greg KH <gregkh@suse.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Kay Sievers <kay.sievers@vrfy.org>
> Cc: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks.
> ---
> init/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index eb4b337..d7ac66b 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -606,7 +606,7 @@ config SYSFS_DEPRECATED
> bool
>
> config SYSFS_DEPRECATED_V2
> - bool "enable deprecated sysfs features which may confuse old userspace tools"
> + bool "enable deprecated sysfs features to support old userspace tools"
> depends on SYSFS
> default n
> select SYSFS_DEPRECATED
> --
---
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-12-03 19:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-23 23:56 [PATCH] sysfs: fix SYSFS_DEPRECATED_V2 prompt Randy Dunlap
2009-12-03 8:03 ` Uwe Kleine-König
2009-12-03 16:31 ` Randy Dunlap
2009-12-03 18:58 ` [PATCH] sysfs: deprecated features are to help old tools not to confuse them Uwe Kleine-König
2009-12-03 19:31 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox