Re: [PATCH v4] k10temp: temperature sensor for AMD Family 10h/11h CPUs

Clemens Ladisch
2009-11-26T07:46:43Z

Andrew Morton wrote:
> Clemens Ladisch <clemens@ladisch.de> wrote:
> > This adds a driver for the internal temperature sensor of AMD Family 10h
> > and 11h CPUs.
> > ...
> > +#define REG_HARDWARE_THERMAL_CONTROL 0x64
> > +#define HTC_ENABLE 0x00000001
> > +
> > +#define REG_REPORTED_TEMPERATURE 0xa4
> > +
> > +#define REG_NORTHBRIDGE_CAPABILITIES 0xe8
> > +#define NB_CAP_HTC 0x00000400
>
> These definitions relate to register addresses within the AMD CPUs,
> yes?

Yes, in the PCI configuration space of the internal northbridge.

> I wonder if these should be placed in some header file in
> arch/x86/include/asm/ where other such things are described.

There is no such header. The files that also access PCI cfg registers:
arch/x86/kernel/k8.c
arch/x86/kernel/quirks.c
arch/x86/oprofile/op_model_amd.c
define their own private symbols or use magic numbers.

Best regards,
Clemens