Re: kvmmmu tracing

Avi Kivity
2009-11-24T14:18:06Z

On 11/24/2009 04:08 PM, Johannes Berg wrote:
> On Tue, 2009-11-24 at 12:34 +0200, Avi Kivity wrote:
>
>
>> Um, C can be easily parsed with a C compiler. I don't think you can
>> expect it to be a plain format string and argument list.
>>
> Actually, it turns out that it cannot be parsed even with a C compiler:
>
> ({ const char *ret = p->buffer + p->len; static const char *access_str[]
> = { "---", "--x", "w--", "w-x", "-u-", "-ux", "wu-", "wux" }; union
> kvm_mmu_page_role role;
>
> ...
>
> userspace cannot possibly know from this what "union kvm_mmu_page_role"
> is.
>

We can expose kvm_mmu_page_role, but that's a new can of worms. And
it's certainly not meant to be stable across kernel versions.

--
error compiling committee.c: too many arguments to function