From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933634AbZKYAlD (ORCPT ); Tue, 24 Nov 2009 19:41:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933178AbZKYAlC (ORCPT ); Tue, 24 Nov 2009 19:41:02 -0500 Received: from claw.goop.org ([74.207.240.146]:59616 "EHLO claw.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933068AbZKYAlB (ORCPT ); Tue, 24 Nov 2009 19:41:01 -0500 Message-ID: <4B0C7D21.7010008@goop.org> Date: Tue, 24 Nov 2009 16:41:05 -0800 From: Jeremy Fitzhardinge User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Stephen Rothwell CC: Gregory Haskins , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xensource.com" , Mark McLoughlin , Greg KH , Kay Sievers Subject: Re: linux-next: alacrity tree build failure References: <20091124185843.d2cab90c.sfr@canb.auug.org.au> In-Reply-To: <20091124185843.d2cab90c.sfr@canb.auug.org.au> X-Enigmail-Version: 0.97a Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/09 23:58, Stephen Rothwell wrote: > Today's linux-next build (x86_6 _allmodconfig) failed like this: > > drivers/vbus/built-in.o:(.data+0x0): multiple definition of `dev_attr_modalias' > drivers/xen/built-in.o:(.data+0x46d0): first defined here > > Caused by commit 59aa8f441d27c8470764a513dafa46a77f33e953 ("vbus: add > autoprobe capability to guest"). The DEVICE_ATTR(modalias ...) should > probably be static. I should probably be static in > drivers/xen/xenbus/xenbus_probe.c as well. > All those DEVICE_ATTR()s should be static in that case. Indeed, I guess they should be almost universally? Should DEVICE_ATTR() include the static? (Hm, almost every instance in the kernel already has static; it should probably have been part of the definition from the start, but changing it now would cause a lot of churn.) J