Re: [PATCH 82/86] pata_via: clear UDMA transfer mode bit for PIO and MWDMA

Alan Cox
2009-11-25T17:50:54Z

> /* Set UDMA unless device is not UDMA capable */
> - if (udma_type && t.udma) {
> - u8 cable80_status;
> + if (udma_type) {
> + u8 udma_etc;

This seems odd the original test is that we are a udma controller and
have a udma timing specified. Otherwise there is no point doing any work.

The rest seems to be gratuitious register renaming and makes the patches
hard to review. Please split this sort of stuff up.