Re: [PATCH 05/86] pata_artop: add Power Management support

Sergei Shtylyov
2009-12-01T18:33:49Z

Bartlomiej Zolnierkiewicz wrote:

> There shouldn't be any problems with it as IDE aec62xx host driver
> has been supporting Power Management for over year now.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> ---
> drivers/ata/pata_artop.c | 72 +++++++++++++++++++++++++++++++++--------------
> 1 file changed, 51 insertions(+), 21 deletions(-)

> Index: b/drivers/ata/pata_artop.c
> ===================================================================
> --- a/drivers/ata/pata_artop.c
> +++ b/drivers/ata/pata_artop.c
[...]
> @@ -330,6 +330,33 @@ static struct ata_port_operations atp86x
> .prereset = atp86x_pre_reset,
> };
>
> +static void atp8xx_fixup(struct pci_dev *pdev)
> +{
> + if (pdev->device == 0x0005)
> + /* BIOS may have left us in UDMA, clear it before probe */
> + pci_write_config_byte(pdev, 0x54, 0);
> + else if (pdev->device == 0x0008 || pdev->device == 0x0009) {
> + u8 reg;
> +
> + /* Mac systems come up with some registers not set as we
> + will need them */
> +
> + /* Clear reset & test bits */
> + pci_read_config_byte(pdev, 0x49, &reg);
> + pci_write_config_byte(pdev, 0x49, reg & ~ 0x30);

Space not needed between ~ and 0x30...

MBR, Sergei