Re: [PATCH 82/86] pata_via: clear UDMA transfer mode bit for PIO and MWDMA

Alan Cox
2009-11-25T18:04:46Z

> Do you really find such tidy patch hard to review?

When doing it at speed - yes.

> /* Set UDMA unless device is not UDMA capable */
> - if (udma_type && t.udma) {
> - u8 cable80_status;
> + if (udma_type) {
> + u8 udma_etc;

Ok that makes sense - we in fact could hit this case on a failure
changedown from UDMA to PIO.