From: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
To: Jens Axboe <jens.axboe@oracle.com>, czoccolo@gmail.com
Cc: Vivek Goyal <vgoyal@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] cfq: Make use of service count to estimate the rb_key offset
Date: Thu, 26 Nov 2009 14:20:31 +0800 [thread overview]
Message-ID: <4B0E1E2F.9080604@cn.fujitsu.com> (raw)
Hi Jens, Czoccolo
For the moment, different workload cfq queues are put into different
service trees. But CFQ still uses "busy_queues" to estimate rb_key
offset when inserting a cfq queue into a service tree. I think this
isn't appropriate, and it should make use of service tree count to do
this estimation. This patch is for for-2.6.33 branch.
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
block/cfq-iosched.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 1bcbd8c..467981e 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -600,11 +600,15 @@ cfq_find_next_rq(struct cfq_data *cfqd, struct cfq_queue *cfqq,
static unsigned long cfq_slice_offset(struct cfq_data *cfqd,
struct cfq_queue *cfqq)
{
+ struct cfq_rb_root *service_tree;
+
+ service_tree = service_tree_for(cfqq_prio(cfqq), cfqq_type(cfqq), cfqd);
+
/*
* just an approximation, should be ok.
*/
- return (cfqd->busy_queues - 1) * (cfq_prio_slice(cfqd, 1, 0) -
- cfq_prio_slice(cfqd, cfq_cfqq_sync(cfqq), cfqq->ioprio));
+ return service_tree->count * (cfq_prio_slice(cfqd, 1, 0) -
+ cfq_prio_slice(cfqd, cfq_cfqq_sync(cfqq), cfqq->ioprio));
}
/*
--
1.5.4.rc3
--
Regards
Gui Jianfeng
next reply other threads:[~2009-11-26 6:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 6:20 Gui Jianfeng [this message]
2009-11-26 8:14 ` [PATCH] cfq: Make use of service count to estimate the rb_key offset Jens Axboe
2009-11-26 9:08 ` Corrado Zoccolo
2009-11-27 1:42 ` Gui Jianfeng
2009-11-27 8:16 ` Corrado Zoccolo
2009-11-30 3:02 ` Gui Jianfeng
2009-11-30 8:38 ` Jens Axboe
2009-11-30 15:36 ` Vivek Goyal
2009-11-30 16:01 ` Corrado Zoccolo
2009-11-30 16:46 ` Vivek Goyal
2009-11-30 21:56 ` Corrado Zoccolo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0E1E2F.9080604@cn.fujitsu.com \
--to=guijianfeng@cn.fujitsu.com \
--cc=czoccolo@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox