From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbZK0Tk5 (ORCPT ); Fri, 27 Nov 2009 14:40:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751907AbZK0Tk4 (ORCPT ); Fri, 27 Nov 2009 14:40:56 -0500 Received: from gateway-1237.mvista.com ([206.112.117.35]:64026 "HELO imap.sh.mvista.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1751274AbZK0Tkz (ORCPT ); Fri, 27 Nov 2009 14:40:55 -0500 Message-ID: <4B102B83.1080102@ru.mvista.com> Date: Fri, 27 Nov 2009 22:41:55 +0300 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pata_hpt3x2n: fix overclocked MWDMA0 timing References: <200911271956.55939.bzolnier@gmail.com> In-Reply-To: <200911271956.55939.bzolnier@gmail.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bartlomiej Zolnierkiewicz wrote: > Remove superfluous timings table entry while at it. > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > Sergei, XFER_UDMA_5 timing also looks suspicious, > please take a look when you have a minute, thanks. Yeah, but it's the same as XFER_UDMA_4, so actually underclocked... However, it matches what the HPT371N datasheet and the vendor drivers have. The 'hpt366' driver uses more speedy mode, with 22.5 ns cycle. ;-) MBR, Sergei