From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbZK3I6A (ORCPT ); Mon, 30 Nov 2009 03:58:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752070AbZK3I57 (ORCPT ); Mon, 30 Nov 2009 03:57:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42247 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbZK3I56 (ORCPT ); Mon, 30 Nov 2009 03:57:58 -0500 Message-ID: <4B138909.1000108@redhat.com> Date: Mon, 30 Nov 2009 09:57:45 +0100 From: Stefan Assmann User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4 MIME-Version: 1.0 To: Jeff Garzik CC: linux-pci@vger.kernel.org, Linux Kernel Mailing List , Jesse Barnes , Krzysztof Halasa , Don Dutile , kaneshige.kenji@jp.fujitsu.com Subject: Re: [PATCH] change PCI nomenclature according to PCI-SIG References: <4B110F79.8080405@redhat.com> <4B111ADC.9020800@garzik.org> <4B123A34.5090509@redhat.com> <4B126EEB.1040908@garzik.org> In-Reply-To: <4B126EEB.1040908@garzik.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.11.2009 13:54, Jeff Garzik wrote: > On 11/29/2009 04:09 AM, Stefan Assmann wrote: >> On 28.11.2009 13:43, Jeff Garzik wrote: >>> On 11/28/2009 06:54 AM, Stefan Assmann wrote: >>>> From: Stefan Assmann >>>> >>>> Changing occurrences of variants of PCI-X and PCIe to the PCI-SIG >>>> terms listed in the "Trademark and Logo Usage Guidelines". >>>> http://www.pcisig.com/developers/procedures/logos/Trademark_and_Logo_Usage_Guidelines_updated_112206.pdf >>>> >>>> >>>> Additionally some renames of Gb/s to GT/s where appropriate, concerns >>>> PCIe. >>>> >>>> This is a followup to the discussion at: >>>> http://lkml.org/lkml/2009/10/14/107 >>>> Patch is based on 2.6.32-rc8. >>>> >>>> Signed-off-by: Stefan Assmann >>> >>> NAK, this clearly introduces bugs and changes sysfs output (ABI). >>> >>> Typically this type of change is pointless churn that creates far more >>> problems than it "solves." >> >> Hi Jeff, >> >> I see you point in not liking this kind of change. What kind of cleanup >> would be ok in your opinion? > > Think about this from an engineering perspective. This patch is driven > not by any real technical need, but more by marketing and trademark folks. > > The absolute best case scenario for this patch is that nothing changes, > from an implementation and behavior standpoint. The worst case, of > course, is that it introduces bugs (which it does). > > You also incur the standard costs of any kernel change: you've just > made the diff between, for example, a vendor kernel's foo_driver.c and > upstream's foo_driver.c a lot larger, and more difficult to discern > real, technical changes to the code. > > Of course, we change the kernel every day -- but we also know that > change itself has cost, and a lot of code changes for cosmetic reasons > have the potential for greater negative costs, and fewer positive benefits. > > Next, IMO, you don't have any idea how maintainers will react to this > patch, because you CC'd so few of them. People who perform tree-wide > changes should take the time to CC __every__ relevant maintainer. If > you are changing somebody's code, you should always let them know about > it, and give them an opportunity to review the change. > scripts/get_maintainer.pl can help with this. > > So, while the PCI maintainer might agree with the nomenclature change, > he is not the most qualified person to state that your changes have no > effect on drivers/edac/ppc4xx_edac.c, for example. > > Finally, split your patch up. I would suggest starting with 100% > comment changes that are guaranteed with mathematical certainty to not > change the compiler-generated code at all. That will make the remaining > changes much easier to review, if they are in separate patches from the > comment-only changes. Thanks for taking the time. I appreciate it and will try to stick to your suggestions. Stefan -- Stefan Assmann | Red Hat GmbH Software Engineer | Otto-Hahn-Strasse 20, 85609 Dornach | HR: Amtsgericht Muenchen HRB 153243 | GF: Brendan Lane, Charlie Peters, sassmann at redhat.com | Michael Cunningham, Charles Cachera