From: Tejun Heo <tj@kernel.org>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [Patch] percpu: remove two suspicious break statements
Date: Mon, 30 Nov 2009 20:09:33 +0900 [thread overview]
Message-ID: <4B13A7ED.9010905@kernel.org> (raw)
In-Reply-To: <20091130091501.4507.28683.sendpatchset@localhost.localdomain>
On 11/30/2009 06:12 PM, Amerigo Wang wrote:
> These two break statements seem to be very suspicious,
> they are at the end of the statements inside the loop.
> Remove them.
>
> Signed-off-by: WANG Cong <amwang@redhat.com>
> Cc: Tejun Heo <tj@kernel.org>
That actually is correct code. It's checking whether the first
iteration covers the whole thing. I thought the comment there
/* quick path, check whether all pages are already there */
explained it but looking at it again, it definitely isn't enough
unless you already know what's going on there. Can you please post a
patch to add the comment?
Thanks.
--
tejun
next prev parent reply other threads:[~2009-11-30 11:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 9:12 [Patch] percpu: remove two suspicious break statements Amerigo Wang
2009-11-30 11:09 ` Tejun Heo [this message]
2009-11-30 19:01 ` Christoph Lameter
2009-12-01 0:01 ` [PATCH] percpu: explain quick paths in pcpu_[de]populate_chunk() Tejun Heo
2009-12-01 2:02 ` Cong Wang
2009-12-01 5:00 ` Tejun Heo
2009-12-01 5:09 ` Tejun Heo
2009-12-01 5:40 ` Cong Wang
2009-12-01 5:47 ` Tejun Heo
2009-12-01 6:35 ` Cong Wang
2009-12-01 6:59 ` Tejun Heo
2009-12-01 7:13 ` [PATCH] percpu: refactor the code " Cong Wang
2009-12-01 14:31 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B13A7ED.9010905@kernel.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox