From: "Éric Piel" <eric.piel@tremplin-utc.net>
To: Samu Onkalo <samu.p.onkalo@nokia.com>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH v3 4/5] lis3: Scale output values to mg
Date: Mon, 30 Nov 2009 16:16:18 +0100 [thread overview]
Message-ID: <4B13E1C2.9050403@tremplin-utc.net> (raw)
In-Reply-To: <1258622842-23129-5-git-send-email-samu.p.onkalo@nokia.com>
Op 19-11-09 10:27, Samu Onkalo schreef:
> Report output values as 1/1000 of earth gravity.
:
Looks good, excepted that you have some constants with a very long name.
:
> +#define LIS3_SCALING_ACCURACY 1024
> +#define LIS3_2G2G_SENSITIVITY_WAI_12B ((LIS3_SCALING_ACCURACY * 1000) / 1024)
> +#define LIS3_2G2G_SENSITIVITY_WAI_8B (18 * LIS3_SCALING_ACCURACY)
As you'll have to rebase it anyway for the path 3, could you change
those constants to have a shorter name? At least "WAI" could go away.
And what does 2G2G stands for?
Eric
next prev parent reply other threads:[~2009-11-30 15:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 9:27 [PATCH v3 0/5] lis3: Feature updates Samu Onkalo
2009-11-19 9:27 ` [PATCH v3 1/5] lis3: Selftest support Samu Onkalo
2009-11-19 9:27 ` [PATCH v3 2/5] LIS3LV02D: Remove calibaration functionality Samu Onkalo
2009-11-19 9:27 ` [PATCH v3 3/5] lis3: Sysfs entry for setting chip measurement rate Samu Onkalo
2009-11-19 9:27 ` [PATCH v3 4/5] lis3: Scale output values to mg Samu Onkalo
2009-11-19 9:27 ` [PATCH v3 5/5] LIS3: Update documentation to match latest changes Samu Onkalo
2009-11-30 15:18 ` Éric Piel
2009-11-30 15:16 ` Éric Piel [this message]
2009-11-30 15:12 ` [PATCH v3 3/5] lis3: Sysfs entry for setting chip measurement rate Éric Piel
2009-11-30 15:09 ` [PATCH v3 2/5] LIS3LV02D: Remove calibaration functionality Éric Piel
2009-11-30 14:56 ` [PATCH v3 1/5] lis3: Selftest support Éric Piel
2009-11-30 15:25 ` Éric Piel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B13E1C2.9050403@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox