public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Alan Cox <alan@linux.intel.com>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] staging: fix a silly typo
Date: Mon, 30 Nov 2009 08:09:33 -0800	[thread overview]
Message-ID: <4B13EE3D.4030704@oracle.com> (raw)
In-Reply-To: <20091130132432.27394.48685.stgit@localhost.localdomain>

Alan Cox wrote:
> (Resend #3)

> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
I have also sent this patch a few times.

The problems are in Rusty Russell's quilt series/tree and he replied to me
that he fixed them, but they don't seem to be pushed yet....

Rusty?


>  drivers/staging/rtl8187se/r8180_core.c  |    2 +-
>  drivers/staging/rtl8192su/r8192U_core.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index 5a6cd60..d74bf70 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -79,7 +79,7 @@ MODULE_AUTHOR("Andrea Merello <andreamrl@tiscali.it>");
>  MODULE_DESCRIPTION("Linux driver for Realtek RTL8180 / RTL8185 WiFi cards");
>  
>  
> -module_param_string(ifname, ifname, sizef(ifname), S_IRUGO|S_IWUSR);
> +module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO|S_IWUSR);
>  module_param(hwseqnum,int, S_IRUGO|S_IWUSR);
>  module_param(hwwep,int, S_IRUGO|S_IWUSR);
>  module_param(channels,int, S_IRUGO|S_IWUSR);
> diff --git a/drivers/staging/rtl8192su/r8192U_core.c b/drivers/staging/rtl8192su/r8192U_core.c
> index e24815f..0a052ea 100644
> --- a/drivers/staging/rtl8192su/r8192U_core.c
> +++ b/drivers/staging/rtl8192su/r8192U_core.c
> @@ -142,7 +142,7 @@ static int channels = 0x3fff;
>  
>  
>  
> -module_param_string(ifname, ifname, sizef(ifname), S_IRUGO|S_IWUSR);
> +module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO|S_IWUSR);
>  //module_param(hwseqnum,int, S_IRUGO|S_IWUSR);
>  module_param(hwwep,int, S_IRUGO|S_IWUSR);
>  module_param(channels,int, S_IRUGO|S_IWUSR);


-- 
~Randy

  reply	other threads:[~2009-11-30 16:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30 13:24 [PATCH] staging: fix a silly typo Alan Cox
2009-11-30 16:09 ` Randy Dunlap [this message]
2009-11-30 16:14 ` Greg KH
2009-11-30 16:39   ` Alan Cox
2009-11-30 16:59     ` Greg KH
2009-12-01  2:07       ` Rusty Russell
2009-12-01  1:58   ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B13EE3D.4030704@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=alan@linux.intel.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox