* Subject: [PATCH 2/2] fix a Section mismatch in arch/x86/pci/mmconfig-shared.c and include/linux/sfi_acpi.h
@ 2009-11-30 10:38 helight
2009-11-30 19:18 ` H. Peter Anvin
0 siblings, 1 reply; 4+ messages in thread
From: helight @ 2009-11-30 10:38 UTC (permalink / raw)
To: linux-kernel; +Cc: x86, H. Peter Anvin, Ingo Molnar, Thomas Gleixner
acpi_sfi_table_parse() should be __init. tested on x86 system!
warning msg:
WARNING: vmlinux.o(.text+0x322e69): Section mismatch in reference from
the function acpi_sfi_table_parse() to the function
.init.text:acpi_table_parse()
The function acpi_sfi_table_parse() references
the function __init acpi_table_parse().
This is often because acpi_sfi_table_parse lacks a __init
annotation or the annotation of acpi_table_parse is wrong.
Signed-off-by: ZhenwenXu <helight.xu@gmail.com>
---
include/linux/sfi_acpi.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/sfi_acpi.h b/include/linux/sfi_acpi.h
index c4a5a8c..631af63 100644
--- a/include/linux/sfi_acpi.h
+++ b/include/linux/sfi_acpi.h
@@ -66,7 +66,7 @@ extern int sfi_acpi_table_parse(char *signature, char
*oem_id,
char *oem_table_id,
int (*handler)(struct acpi_table_header *));
-static inline int acpi_sfi_table_parse(char *signature,
+static inline int __init acpi_sfi_table_parse(char *signature,
int (*handler)(struct acpi_table_header *))
{
if (!acpi_table_parse(signature, handler))
@@ -83,7 +83,7 @@ static inline int sfi_acpi_table_parse(char
*signature, char *oem_id,
return -1;
}
-static inline int acpi_sfi_table_parse(char *signature,
+static inline int __init acpi_sfi_table_parse(char *signature,
int (*handler)(struct acpi_table_header *))
{
return acpi_table_parse(signature, handler);
--
1.6.5.3
--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: Subject: [PATCH 2/2] fix a Section mismatch in arch/x86/pci/mmconfig-shared.c and include/linux/sfi_acpi.h
2009-11-30 10:38 Subject: [PATCH 2/2] fix a Section mismatch in arch/x86/pci/mmconfig-shared.c and include/linux/sfi_acpi.h helight
@ 2009-11-30 19:18 ` H. Peter Anvin
2009-12-01 1:02 ` helight
2009-12-01 1:09 ` Helight.Xu
0 siblings, 2 replies; 4+ messages in thread
From: H. Peter Anvin @ 2009-11-30 19:18 UTC (permalink / raw)
To: Brown, Len; +Cc: helight, linux-kernel, x86, Ingo Molnar, Thomas Gleixner
Hi Len,
Do you want to take this one or should I?
-hpa
On 11/30/2009 02:38 AM, helight wrote:
> acpi_sfi_table_parse() should be __init. tested on x86 system!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Subject: [PATCH 2/2] fix a Section mismatch in arch/x86/pci/mmconfig-shared.c and include/linux/sfi_acpi.h
2009-11-30 19:18 ` H. Peter Anvin
@ 2009-12-01 1:02 ` helight
2009-12-01 1:09 ` Helight.Xu
1 sibling, 0 replies; 4+ messages in thread
From: helight @ 2009-12-01 1:02 UTC (permalink / raw)
To: H. Peter Anvin
Cc: Brown, Len, linux-kernel, x86, Ingo Molnar, Thomas Gleixner
H. Peter Anvin wrote:
> Hi Len,
>
> Do you want to take this one or should I?
>
ooh! both ok！thing is that we fix the problem!
> -hpa
>
>
> On 11/30/2009 02:38 AM, helight wrote:
>
>> acpi_sfi_table_parse() should be __init. tested on x86 system!
>>
>
>
--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Subject: [PATCH 2/2] fix a Section mismatch in arch/x86/pci/mmconfig-shared.c and include/linux/sfi_acpi.h
2009-11-30 19:18 ` H. Peter Anvin
2009-12-01 1:02 ` helight
@ 2009-12-01 1:09 ` Helight.Xu
1 sibling, 0 replies; 4+ messages in thread
From: Helight.Xu @ 2009-12-01 1:09 UTC (permalink / raw)
To: H. Peter Anvin
Cc: Brown, Len, linux-kernel, x86, Ingo Molnar, Thomas Gleixner
H. Peter Anvin wrote:
> Hi Len,
>
> Do you want to take this one or should I?
>
ooh! both ok！thing is that we fix the problem!
> -hpa
>
>
> On 11/30/2009 02:38 AM, helight wrote:
>
>> acpi_sfi_table_parse() should be __init. tested on x86 system!
>>
>
>
--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-12-01 1:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-30 10:38 Subject: [PATCH 2/2] fix a Section mismatch in arch/x86/pci/mmconfig-shared.c and include/linux/sfi_acpi.h helight
2009-11-30 19:18 ` H. Peter Anvin
2009-12-01 1:02 ` helight
2009-12-01 1:09 ` Helight.Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox