From: Michal Marek <mmarek@suse.cz>
To: Tony Finch <dot@dotat.at>
Cc: Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
"Justin P. Mattock" <justinmattock@gmail.com>
Subject: Re: [PATCHv2] unifdef: update to upstream revision 1.190
Date: Tue, 01 Dec 2009 17:12:29 +0100 [thread overview]
Message-ID: <4B15406D.6010800@suse.cz> (raw)
In-Reply-To: <E1NFU0t-0002UG-0R@hermes-1.csi.cam.ac.uk>
On 27.11.2009 16:50, Tony Finch wrote:
> Fix handling of input files (e.g. with no newline at EOF) that could
> make unifdef get into an unexpected state and call abort().
>
> The new -B option compresses blank lines around a deleted section
> so that blank lines around "paragraphs" of code don't get doubled.
>
> The evaluator can now handle macros with arguments, and unbracketed
> arguments to the "defined" operator.
>
> Add myself to MAINTAINERS for unifdef.
>
> Obtained-from: http://dotat.at/prog/unifdef/
> Signed-off-by: Tony Finch <dot@dotat.at>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
Thanks, applied. I remove the Obtained-from: line because I didn't find
prior use of it and you list your website in MAINTAINERS anyway. I
assume Sam's ack still holds because the changes you mention are
trivial. BTW, scripts/checkpatch.pl reports some coding style issues
(mostly parentheses in return statements and opening braces directly
after function declarations), but as this is not original kernel source
but a copy of one file from another project, I think we should be
lenient here.
Michal
next prev parent reply other threads:[~2009-12-01 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 13:15 [PATCH] unifdef: update to upstream revision 1.189 Michal Marek
2009-11-27 21:04 ` Sam Ravnborg
[not found] ` <E1NE3M6-0003Za-OJ@hermes-1.csi.cam.ac.uk>
2009-11-27 18:17 ` Sam Ravnborg
2009-11-27 19:15 ` Tony Finch
2009-11-27 15:50 ` [PATCHv2] unifdef: update to upstream revision 1.190 Tony Finch
2009-12-01 16:12 ` Michal Marek [this message]
2009-12-01 16:21 ` Tony Finch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B15406D.6010800@suse.cz \
--to=mmarek@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=dot@dotat.at \
--cc=joe@perches.com \
--cc=justinmattock@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox