public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	rostedt@goodmis.org, jbaron@redhat.com, tglx@linutronix.de,
	mingo@elte.hu, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] trace_syscalls: Remove unused	event_syscall_enter and event_syscall_exit
Date: Wed, 02 Dec 2009 09:13:50 +0800	[thread overview]
Message-ID: <4B15BF4E.2000606@cn.fujitsu.com> (raw)
In-Reply-To: <20091201175403.GC5080@nowhere>

Frederic Weisbecker wrote:

> 
> Except for this patch. The whole series is really nice, thanks
> a lot for this cleanup!
> 
> 
> 

> But I think you fixed it the wrong way.
> 
> Why do we need a copy of this event_syscall_enter
> for each syscall event?
> Can't we actually drop enter_syscall_print_##sname
> and always use event_syscall_enter instead?
> 
> The same applies to exit syscall events.
> 
> Thanks.
> 

64c12e0444fcc6b75eb49144ba46d43dbdc6bc8f is a nice patch from
Jason Baron, this patch introduces enter_syscall_print_##sname.

This patch only forgot to do some cleanups. My patch make up it:

fix event_enter_##sname->event
fix event_exit_##sname->event

remove unused event_syscall_enter and event_syscall_exit

Thanks,
Lai

commit 64c12e0444fcc6b75eb49144ba46d43dbdc6bc8f
Author: Jason Baron <jbaron@redhat.com>
Date:   Mon Aug 10 16:52:53 2009 -0400

    tracing: Add individual syscalls tracepoint id support

    The current state of syscalls tracepoints generates only one event id
    for every syscall events.

    This patch associates an id with each syscall trace event, so that we
    can identify each syscall trace event using the 'perf' too

  reply	other threads:[~2009-12-02  1:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01  8:23 [PATCH 1/7] trace_syscalls: remove unused event_syscall_enter and event_syscall_exit Lai Jiangshan
2009-12-01 16:42 ` [tip:perf/core] trace_syscalls: Remove " tip-bot for Lai Jiangshan
2009-12-01 17:40   ` Frederic Weisbecker
2009-12-01 17:54   ` Frederic Weisbecker
2009-12-02  1:13     ` Lai Jiangshan [this message]
2009-12-02  4:24       ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B15BF4E.2000606@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox