From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: pancho horrillo <pancho@pancho.name>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Fix a bug on appledisplay.c regarding signedness
Date: Wed, 02 Dec 2009 22:38:27 +0300 [thread overview]
Message-ID: <4B16C233.6020808@ru.mvista.com> (raw)
In-Reply-To: <20091202193104.GB7362@pancho.name>
Hello.
pancho horrillo wrote:
> Please, review and push the patch, if you deem it adequate.
> Thanks a bunch!
> Signed-off-by: pancho horrillo <pancho@pancho.name>
> diff -purN a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c
> --- a/drivers/usb/misc/appledisplay.c 2009-11-10 01:32:31.000000000 +0100
> +++ b/drivers/usb/misc/appledisplay.c 2009-12-02 20:05:00.000000000 +0100
> @@ -72,8 +72,8 @@ struct appledisplay {
> struct usb_device *udev; /* usb device */
> struct urb *urb; /* usb request block */
> struct backlight_device *bd; /* backlight device */
> - char *urbdata; /* interrupt URB data buffer */
> - char *msgdata; /* control message data buffer */
> + uint8_t *urbdata; /* interrupt URB data buffer */
> + uint8_t *msgdata; /* control message data buffer */
That 'uint8_t' is for userspace, use 'u8' instead.
WBR, Sergei
next prev parent reply other threads:[~2009-12-02 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 19:19 [PATCH 1/2] Add USB device ID for Apple Cinema Display 23in 2007 pancho horrillo
2009-12-02 19:31 ` [PATCH 2/2] Fix a bug on appledisplay.c regarding signedness pancho horrillo
2009-12-02 19:38 ` Sergei Shtylyov [this message]
2009-12-02 20:44 ` pancho horrillo
2009-12-03 3:20 ` Greg KH
2009-12-22 19:29 ` Greg KH
2009-12-23 10:09 ` pancho horrillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B16C233.6020808@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pancho@pancho.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox