public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jin Dongming <jin.dongming@np.css.fujitsu.com>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Cc: LKLM <linux-kernel@vger.kernel.org>
Subject: Question about kmsg_dump for OOPS
Date: Thu, 03 Dec 2009 12:04:46 +0900	[thread overview]
Message-ID: <4B172ACE.7080806@np.css.fujitsu.com> (raw)

Hello, Simon

I am Jin Dongming.

I have a question about kmsg_dump which needs your help.
The question is as following:
    Why not put the kmsg_dump() for OOPS into oops_end() and before the branch
    of crash_kexec()?

The reason for the question is as following:
    Now the kmsg_dump() for OOPS is added in oops_exit(). When OOPS happened,
    kernel will call oops_end(). If the crash_kexec() is executed first in
    oops_end(), the oops_exit() could not be called. And also the kmsg_dump()
    for PANIC could not be executed. So I think that the kmsg_dump() for OOPS
    will lose its real meaning.
    
    The function tree for OOPS is as following:
      oops_end()
        |
        |-- if (crash_kexec is valid)
        |      |
        |      |-- crash_kexec()    ==> reboot (and the following function will
        |                                       not be executed)
        |
        |-- oops_exit
        |      |
        |      |-- kmsg_dump(OOPS)
        |
        |-- if (panic is valid)
        |      |
        |      |-- kmsg_dump(PANIC)
        |

    The function tree for PANIC is as following:
      panic()
        |
        |-- kmsg_dump(PANIC)
        |
        |-- crash_kexec()
        |
        |-- notifier()


When kernel paniced, kmsg_dump() for PANIC is executed before crash_kexec(). So
I think before crash_kexec() is executed, kmsg_dump() for OOPS should be called
too. How do you think?

Best regards,
Jin Dongming


             reply	other threads:[~2009-12-03  3:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03  3:04 Jin Dongming [this message]
2009-12-03  8:26 ` Question about kmsg_dump for OOPS Simon Kagstrom
2009-12-04  0:54   ` Jin Dongming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B172ACE.7080806@np.css.fujitsu.com \
    --to=jin.dongming@np.css.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simon.kagstrom@netinsight.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox