From: Masami Hiramatsu <mhiramat@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
DLE <dle-develop@lists.sourceforge.net>,
Oleg Nesterov <oleg@redhat.com>,
Roland McGrath <roland@redhat.com>,
Jason Baron <jbaron@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH v2] [RFC] tracepoint: Add signal coredump tracepoint
Date: Thu, 03 Dec 2009 06:32:29 -0500 [thread overview]
Message-ID: <4B17A1CD.8060706@redhat.com> (raw)
In-Reply-To: <20091203103935.GA7628@elte.hu>
Ingo Molnar wrote:
>
> * Masami Hiramatsu <mhiramat@redhat.com> wrote:
>
>> Add signal coredump tracepoint which shows signal number, mm->flags,
>> limits, pointer to file structure and core file name.
>
> Why is the kernel pointer to the file structure logged? User-space has
> no use for it and the analysis value is low.
Ah, if open() or opening pipe fails, it becomes 0 or -ERRNO,
so we can check if there is an error.
Perhaps, we can do below in trace_printk for trace users.
"open %s", (!file || IS_ERR((void *)file)) ? "failed" : "succeeded"
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2009-12-03 11:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200911202212.nAKMCF2v012068@imap1.linux-foundation.org>
2009-11-26 8:53 ` + binfmt-introduce-coredump-parameter-structure.patch added to -mm tree KOSAKI Motohiro
2009-11-26 15:50 ` Masami Hiramatsu
2009-11-26 16:51 ` Oleg Nesterov
2009-11-29 3:59 ` Masami Hiramatsu
2009-11-29 4:39 ` [PATCH v2] mm: Introduce coredump parameter structure Masami Hiramatsu
2009-11-29 4:41 ` Masami Hiramatsu
2009-11-29 15:10 ` [PATCH][RFC] tracepoint: signal coredump (Re: [PATCH v2] mm: Introduce coredump parameter structure) Masami Hiramatsu
2009-12-02 20:46 ` [PATCH v2] [RFC] tracepoint: Add signal coredump tracepoint Masami Hiramatsu
2009-12-03 10:39 ` Ingo Molnar
2009-12-03 11:32 ` Masami Hiramatsu [this message]
2009-12-05 7:16 ` Ingo Molnar
2009-12-07 17:19 ` Masami Hiramatsu
2009-12-05 7:18 ` KOSAKI Motohiro
2009-12-07 15:25 ` Masami Hiramatsu
2009-12-08 1:51 ` KOSAKI Motohiro
2009-12-08 20:40 ` [PATCH v3] " Masami Hiramatsu
2009-12-09 5:34 ` KOSAKI Motohiro
2009-12-09 16:07 ` Masami Hiramatsu
2009-12-09 16:16 ` Masami Hiramatsu
2009-12-09 20:38 ` [PATCH v4] " Masami Hiramatsu
2009-12-10 0:09 ` KOSAKI Motohiro
2009-12-02 0:18 ` [PATCH v2] mm: Introduce coredump parameter structure Andrew Morton
2009-12-02 0:27 ` KOSAKI Motohiro
2009-12-02 0:29 ` Masami Hiramatsu
2009-12-02 9:50 ` Ingo Molnar
2009-12-02 18:07 ` Masami Hiramatsu
2009-12-02 0:41 ` [PATCH v2] [RESEND] " Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B17A1CD.8060706@redhat.com \
--to=mhiramat@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dle-develop@lists.sourceforge.net \
--cc=jbaron@redhat.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox