From: "H. Peter Anvin" <hpa@zytor.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, "Cihula, Joseph" <joseph.cihula@intel.com>,
Shane Wang <shane.wang@intel.com>
Subject: Re: [PATCH] x86: Put trampoline_data into readonly section.
Date: Fri, 04 Dec 2009 22:16:53 -0800 [thread overview]
Message-ID: <4B19FAD5.5020802@zytor.com> (raw)
In-Reply-To: <b9df5fa10912042047i7b6b84e2n2d2a5441d721b3ca@mail.gmail.com>
On 12/04/2009 08:47 PM, Rakib Mullick wrote:
> On 12/5/09, H. Peter Anvin<hpa@zytor.com> wrote:
>> On 12/04/2009 08:24 AM, Rakib Mullick wrote:
>>
>> Perhaps the better thing would be to define trampoline_size as an
>> absolute symbol in arch/x86/kernel/trampoline_*.S, especially since it
>> probably generates bad code to subtract two global symbols like that.
>>
> But - trampoline_data is placed into - cpu init readonly data section.
> And we are
> referencing it from non-cpuinit function. ....... so I think the
> problem remains.
> Isn't it ? Or am I missing anything?
>
No, we're not actually referencing it at all. We're just using its
length, whereas in reality we actually have copied the code elsewhere
already.
-hpa
prev parent reply other threads:[~2009-12-05 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 16:24 [PATCH] x86: Put trampoline_data into readonly section Rakib Mullick
2009-12-05 1:19 ` H. Peter Anvin
2009-12-05 4:47 ` Rakib Mullick
2009-12-05 6:16 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B19FAD5.5020802@zytor.com \
--to=hpa@zytor.com \
--cc=joseph.cihula@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rakib.mullick@gmail.com \
--cc=shane.wang@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox