From: William Allen Simpson <william.allen.simpson@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Brice Goglin <brice@myri.com>, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org,
Linux Kernel Developers <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] drivers/net: Move && and || to end of previous line
Date: Sat, 05 Dec 2009 07:43:41 -0500 [thread overview]
Message-ID: <4B1A557D.4080707@gmail.com> (raw)
In-Reply-To: <1259947271.22783.120.camel@Joe-Laptop.home>
Joe Perches wrote:
> On Fri, 2009-12-04 at 14:10 +0100, Brice Goglin wrote:
>> Joe Perches wrote:
>>> Only files where David Miller is the primary git-signer.
>>> wireless, wimax, ixgbe, etc are not modified.
>> What's the point? Having them at the beginning of the next line is
>> easier to read from my point of view.
>
> It's just a stupid consistency thing.
>
Brice, I've made my objection known on the LKML. Joe *agrees* that
having them on the beginning of the line is preferred. Thousands of
contributors throughout the tree agree.
This is entirely a Miller thing.
My main objection to these sweeping patches is that it makes it much
more difficult to maintain and apply patches across different versions of
the tree. We have already seen conflicts with other git maintained trees.
These patches should not be accepted to the main Linus tree.
next prev parent reply other threads:[~2009-12-05 12:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1259001504.16503.79.camel@Joe-Laptop.home>
[not found] ` <20091123.104130.117837098.davem@davemloft.net>
[not found] ` <1259528449.29779.194.camel@Joe-Laptop.home>
[not found] ` <20091129.165557.84377714.davem@davemloft.net>
[not found] ` <20091130092837.4998f961@nehalam>
2009-12-01 4:13 ` [PATCH] drivers/block/floppy.c: stylistic cleanups Joe Perches
2009-12-01 16:45 ` Stephen Hemminger
2009-12-01 19:09 ` Bartlomiej Zolnierkiewicz
2009-12-01 17:36 ` Marcin Slusarz
2009-12-01 17:46 ` Joe Perches
2009-12-01 18:39 ` Bartlomiej Zolnierkiewicz
[not found] ` <1259863101.22783.63.camel@Joe-Laptop.home>
[not found] ` <4B190A29.5080905@myri.com>
[not found] ` <1259947271.22783.120.camel@Joe-Laptop.home>
2009-12-05 12:43 ` William Allen Simpson [this message]
2009-12-05 17:50 ` [PATCH net-next-2.6] drivers/net: Move && and || to end of previous line Joe Perches
2009-12-05 22:05 ` Jarek Poplawski
2009-12-06 3:36 ` William Allen Simpson
2009-12-05 22:21 ` David Miller
2009-12-06 3:00 ` William Allen Simpson
2009-12-06 17:01 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1A557D.4080707@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=brice@myri.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox