public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick Ringl <patrick_@freenet.de>
To: linux-kernel@vger.kernel.org
Cc: alan@redhat.com
Subject: [PATCH]: drivers/platform/x86/Kconfig - fix inconsistency
Date: Sun, 06 Dec 2009 03:13:10 +0100	[thread overview]
Message-ID: <4B1B1336.5020309@freenet.de> (raw)

Hi,

I just discovered an inconsistency in a Kconfig file. DELL_WMI as well 
as HP_WMI should not depend on ACPI_WMI but select it, as all the other 
WMI-related,  platform-specific device drivers like TC1100_WMI or 
ACER_WMI do.

This -as of right now- prevents the selection of the two initially 
mentioned drivers unless one, by chance, enables ACPI_WMI and then goes 
back.


Signed-off-by: Patrick Ringl <patrick_@freenet.de>

--- linux-2.6.32-o/drivers/platform/x86/Kconfig    2009-12-03 
04:51:21.000000000 +0100
+++ linux-2.6.32/drivers/platform/x86/Kconfig    2009-12-06 
02:32:47.000000000 +0100
@@ -86,8 +86,8 @@
 
 config DELL_WMI
     tristate "Dell WMI extras"
-    depends on ACPI_WMI
     depends on INPUT
+    select ACPI_WMI
     ---help---
       Say Y here if you want to support WMI-based hotkeys on Dell laptops.
 
@@ -133,9 +133,9 @@
 
 config HP_WMI
     tristate "HP WMI extras"
-    depends on ACPI_WMI
     depends on INPUT
     depends on RFKILL || RFKILL = n
+    select ACPI_WMI
     help
      Say Y here if you want to support WMI-based hotkeys on HP laptops and
      to read data from WMI such as docking or ambient light sensor state.
---



regards,
Patrick

             reply	other threads:[~2009-12-06  2:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-06  2:13 Patrick Ringl [this message]
2009-12-06 17:59 ` [PATCH]: drivers/platform/x86/Kconfig - fix inconsistency Randy Dunlap
2009-12-06 17:32   ` Patrick Ringl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B1B1336.5020309@freenet.de \
    --to=patrick_@freenet.de \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox