From: "H. Peter Anvin" <hpa@zytor.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: mingo@elte.hu, jirislaby@gmail.com, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org
Subject: Re: [PATCH 1/1] X86: use explicit register name for get/put_user
Date: Sun, 06 Dec 2009 11:11:48 -0800 [thread overview]
Message-ID: <4B1C01F4.8020304@zytor.com> (raw)
In-Reply-To: <1260091808-8053-1-git-send-email-jslaby@suse.cz>
On 12/06/2009 01:30 AM, Jiri Slaby wrote:
>
> I don't know if this could ever cause any problems, but changing
> the input to an explicit register ("a") makes it cleaner in my eyes.
> There is no need of the back reference.
>
It can't: the backreference refers to only the information that is in
the register constraint, not to anything else. I really would prefer
avoiding any changes to working code that aren't justified, simply
because every time we change an asm() we risk tickling a new obscure bug
in some old version of gcc.
As such,
Nacked-by: H. Peter Anvin <hpa@zytor.com>
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-12-06 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 9:30 [PATCH 1/1] X86: use explicit register name for get/put_user Jiri Slaby
2009-12-06 19:11 ` H. Peter Anvin [this message]
2009-12-07 12:37 ` Jiri Slaby
2009-12-07 18:35 ` H. Peter Anvin
2009-12-09 20:03 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1C01F4.8020304@zytor.com \
--to=hpa@zytor.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox