From: Thomas Backlund <tmb@mandriva.org>
To: Greg KH <greg@kroah.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
stable@kernel.org
Subject: Re: [stable] x86: Remove STACKPROTECTOR_ALL
Date: Mon, 07 Dec 2009 01:24:21 +0200 [thread overview]
Message-ID: <4B1C3D25.4010903@mandriva.org> (raw)
In-Reply-To: <20091205195852.GC21172@kroah.com>
Greg KH skrev:
> On Wed, Nov 11, 2009 at 12:23:16AM +0200, Thomas Backlund wrote:
>> I think this one should go to 2.6.31.x too ...
>>
>>> Gitweb: http://git.kernel.org/linus/14a3f40aafacde1dfd6912327ae14df4baf10304
>>> Commit: 14a3f40aafacde1dfd6912327ae14df4baf10304
>>> Parent: 02dd0a0613e0d84c7dd8315e3fe6204d005b7c79
>>> Author: Arjan van de Ven <arjan@infradead.org>
>>> AuthorDate: Fri Oct 23 07:31:01 2009 -0700
>>> Committer: Ingo Molnar <mingo@elte.hu>
>>> CommitDate: Fri Oct 23 16:35:23 2009 +0200
>>>
>>> x86: Remove STACKPROTECTOR_ALL
>>>
>>> STACKPROTECTOR_ALL has a really high overhead (runtime and stack
>>> footprint) and is not really worth it protection wise (the
>>> normal STACKPROTECTOR is in effect for all functions with
>>> buffers already), so lets just remove the option entirely.
>>>
>>> Reported-by: Dave Jones <davej@redhat.com>
>>> Reported-by: Chuck Ebbert <cebbert@redhat.com>
>>> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
>>> Cc: Eric Sandeen <sandeen@redhat.com>
>>> LKML-Reference: <20091023073101.3dce4ebb@infradead.org>
>>> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>
> It doesn't really "fix" anything, so I'd prefer not too.
>
The reason for I suggested it was that is's supposed to remove some
bloating, and reportedly xfs from blowing up:
http://marc.info/?l=linux-kernel&m=125614028227106&w=2
But anyway, it's your call...
--
Thomas
prev parent reply other threads:[~2009-12-06 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200911021859.nA2Ix4cB023712@hera.kernel.org>
2009-11-10 22:23 ` x86: Remove STACKPROTECTOR_ALL Thomas Backlund
2009-12-05 19:58 ` [stable] " Greg KH
2009-12-06 23:24 ` Thomas Backlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1C3D25.4010903@mandriva.org \
--to=tmb@mandriva.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox