From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Xiao Guangrong <ericxiao.gr@gmail.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@elte.hu>,
"Frederic Weisbecker" <fweisbec@gmail.com>,
"Paul Mackerras" <paulus@samba.org>,
"Török Edwin" <edwintorok@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] perf/sched: fix for getting task's execution time
Date: Mon, 07 Dec 2009 15:20:36 +0800 [thread overview]
Message-ID: <4B1CACC4.3030709@cn.fujitsu.com> (raw)
In-Reply-To: <4B1BE588.8020608@gmail.com>
In current code, task's execute time is got by reading
'/proc/<pid>/sched' file, it's wrong if the task is created
by pthread_create(), because every thread task has same pid.
This way also has two demerits:
1: 'perf sched replay' can't work if the kernel not compile with
'CONFIG_SCHED_DEBUG' option
2: perf tool should depend on proc file system
So, this patch call getrusage() to get task's execution time instead
of reading /proc file
Reported-by: Török Edwin <edwintorok@gmail.com>
Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
---
tools/perf/builtin-sched.c | 46 ++++++++++++++-----------------------------
1 files changed, 15 insertions(+), 31 deletions(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index 19f43fa..bd57994 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -13,7 +13,6 @@
#include "util/debug.h"
#include "util/data_map.h"
-#include <sys/types.h>
#include <sys/prctl.h>
#include <semaphore.h>
@@ -399,49 +398,34 @@ process_sched_event(struct task_desc *this_task __used, struct sched_atom *atom)
}
}
+static u64 get_sum_time(struct rusage *ru)
+{
+ u64 sum;
+
+ sum = ru->ru_utime.tv_sec*1e9 + ru->ru_utime.tv_usec*1e3;
+ sum += ru->ru_stime.tv_sec*1e9 + ru->ru_stime.tv_usec*1e3;
+ return sum;
+}
+
static u64 get_cpu_usage_nsec_parent(void)
{
struct rusage ru;
- u64 sum;
int err;
err = getrusage(RUSAGE_SELF, &ru);
BUG_ON(err);
- sum = ru.ru_utime.tv_sec*1e9 + ru.ru_utime.tv_usec*1e3;
- sum += ru.ru_stime.tv_sec*1e9 + ru.ru_stime.tv_usec*1e3;
-
- return sum;
+ return get_sum_time(&ru);
}
static u64 get_cpu_usage_nsec_self(void)
{
- char filename [] = "/proc/1234567890/sched";
- unsigned long msecs, nsecs;
- char *line = NULL;
- u64 total = 0;
- size_t len = 0;
- ssize_t chars;
- FILE *file;
- int ret;
-
- sprintf(filename, "/proc/%d/sched", getpid());
- file = fopen(filename, "r");
- BUG_ON(!file);
-
- while ((chars = getline(&line, &len, file)) != -1) {
- ret = sscanf(line, "se.sum_exec_runtime : %ld.%06ld\n",
- &msecs, &nsecs);
- if (ret == 2) {
- total = msecs*1e6 + nsecs;
- break;
- }
- }
- if (line)
- free(line);
- fclose(file);
+ struct rusage ru;
+ int err;
- return total;
+ err = getrusage(RUSAGE_THREAD, &ru);
+ BUG_ON(err);
+ return get_sum_time(&ru);
}
static void *thread_func(void *ctx)
--
1.6.1.2
next prev parent reply other threads:[~2009-12-07 7:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 10:57 [PATCH] perf/sched: fix for getting task's execute time Xiao Guangrong
2009-12-06 11:05 ` Peter Zijlstra
2009-12-06 11:06 ` Peter Zijlstra
2009-12-06 11:50 ` Ingo Molnar
2009-12-06 17:10 ` Xiao Guangrong
2009-12-07 7:20 ` Xiao Guangrong [this message]
2009-12-07 7:30 ` [PATCH v2] perf/sched: fix for getting task's execution time Ingo Molnar
2009-12-09 9:51 ` [PATCH v3] " Xiao Guangrong
2009-12-09 9:54 ` Xiao Guangrong
2009-12-09 9:59 ` Ingo Molnar
2009-12-09 9:57 ` Xiao Guangrong
2009-12-09 9:57 ` Ingo Molnar
2009-12-09 10:03 ` [tip:perf/urgent] perf sched: Fix " tip-bot for Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1CACC4.3030709@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=edwintorok@gmail.com \
--cc=ericxiao.gr@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox