* [PATCH] ext3: PTR_ERR return of wrong pointer in setup_new_group_blocks()
@ 2009-12-07 13:50 Roel Kluin
2009-12-07 15:37 ` tytso
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-12-07 13:50 UTC (permalink / raw)
To: Andrew Morton, Andreas Dilger, linux-ext4, Andrew Morton, LKML
Return the PTR_ERR of the correct pointer.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
fs/ext3/resize.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext3/resize.c b/fs/ext3/resize.c
index 8359e7b..5f83b61 100644
--- a/fs/ext3/resize.c
+++ b/fs/ext3/resize.c
@@ -266,7 +266,7 @@ static int setup_new_group_blocks(struct super_block *sb,
goto exit_bh;
if (IS_ERR(gdb = bclean(handle, sb, block))) {
- err = PTR_ERR(bh);
+ err = PTR_ERR(gdb);
goto exit_bh;
}
ext3_journal_dirty_metadata(handle, gdb);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext3: PTR_ERR return of wrong pointer in setup_new_group_blocks()
2009-12-07 13:50 [PATCH] ext3: PTR_ERR return of wrong pointer in setup_new_group_blocks() Roel Kluin
@ 2009-12-07 15:37 ` tytso
0 siblings, 0 replies; 2+ messages in thread
From: tytso @ 2009-12-07 15:37 UTC (permalink / raw)
To: Roel Kluin; +Cc: Andrew Morton, Andreas Dilger, linux-ext4, LKML
On Mon, Dec 07, 2009 at 02:50:11PM +0100, Roel Kluin wrote:
> Return the PTR_ERR of the correct pointer.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Reviewed-by: "Theodore Ts'o" <tytso@mit.edu>
Thanks for pointing this out! I've added a similar patch for ext4 in
the patch queue.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-07 15:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-07 13:50 [PATCH] ext3: PTR_ERR return of wrong pointer in setup_new_group_blocks() Roel Kluin
2009-12-07 15:37 ` tytso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox