From: Li Zefan <lizf@cn.fujitsu.com>
To: Ben Blum <bblum@andrew.cmu.edu>
Cc: linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, akpm@linux-foundation.org,
menage@google.com, netdev@vger.kernel.org
Subject: Re: [RFC] [PATCH 3/5] cgroups: net_cls as module
Date: Tue, 08 Dec 2009 14:07:50 +0800 [thread overview]
Message-ID: <4B1DED36.8080204@cn.fujitsu.com> (raw)
In-Reply-To: <20091204085712.GC18912@andrew.cmu.edu>
> +struct cgroup_subsys net_cls_subsys = {
> + .name = "net_cls",
> + .create = cgrp_create,
> + .destroy = cgrp_destroy,
> + .populate = cgrp_populate,
> +#ifdef CONFIG_NET_CLS_CGROUP
> + .subsys_id = net_cls_subsys_id,
> +#else
> +#define net_cls_subsys_id net_cls_subsys.subsys_id
> +#endif
This looks a bit odd. I think below is the more standard way:
#ifndef MODULES
...
#else
...
#endif
> + .module = THIS_MODULE,
> +};
next prev parent reply other threads:[~2009-12-08 6:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 8:53 [RFC] [PATCH 0/5] cgroups: support for module-loadable subsystems Ben Blum
2009-12-04 8:55 ` [RFC] [PATCH 1/5] cgroups: revamp subsys array Ben Blum
2009-12-08 7:38 ` Li Zefan
2009-12-09 5:50 ` Ben Blum
2009-12-09 6:07 ` Li Zefan
2009-12-09 6:09 ` Li Zefan
2009-12-09 8:27 ` Ben Blum
2009-12-10 3:18 ` Li Zefan
2009-12-10 5:19 ` Ben Blum
2009-12-10 6:00 ` Li Zefan
2009-12-10 6:13 ` Ben Blum
2009-12-09 8:36 ` Ben Blum
2009-12-04 8:56 ` [RFC] [PATCH 2/5] cgroups: subsystem module loading interface Ben Blum
2009-12-04 8:57 ` [RFC] [PATCH 3/5] cgroups: net_cls as module Ben Blum
2009-12-08 6:07 ` Li Zefan [this message]
2009-12-04 8:58 ` [RFC] [PATCH 4/5] cgroups: subsystem module unloading Ben Blum
2009-12-04 8:58 ` [RFC] [PATCH 5/5] cgroups: subsystem dependencies Ben Blum
2009-12-08 6:11 ` Li Zefan
2009-12-09 1:08 ` Ben Blum
2009-12-09 1:40 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1DED36.8080204@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bblum@andrew.cmu.edu \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox