* [PATCH] x86, mce: fix wrong change in mce_create_device
@ 2009-12-08 7:52 Hidetoshi Seto
2009-12-08 20:12 ` [tip:x86/urgent] x86, mce: fix confusion between bank attributes and mce attributes tip-bot for Hidetoshi Seto
0 siblings, 1 reply; 2+ messages in thread
From: Hidetoshi Seto @ 2009-12-08 7:52 UTC (permalink / raw)
To: linux-kernel; +Cc: Ingo Molnar, H. Peter Anvin, Thomas Gleixner
commit cebe182033f156b430952370fb0f9dbe6e89b081 had an unnecessary,
wrong change. Fix it.
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
---
arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index a96e5cd..a8aacd4 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1929,7 +1929,7 @@ error2:
sysdev_remove_file(&per_cpu(mce_dev, cpu), &mce_banks[j].attr);
error:
while (--i >= 0)
- sysdev_remove_file(&per_cpu(mce_dev, cpu), &mce_banks[i].attr);
+ sysdev_remove_file(&per_cpu(mce_dev, cpu), mce_attrs[i]);
sysdev_unregister(&per_cpu(mce_dev, cpu));
--
1.6.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:x86/urgent] x86, mce: fix confusion between bank attributes and mce attributes
2009-12-08 7:52 [PATCH] x86, mce: fix wrong change in mce_create_device Hidetoshi Seto
@ 2009-12-08 20:12 ` tip-bot for Hidetoshi Seto
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Hidetoshi Seto @ 2009-12-08 20:12 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, hpa, mingo, andi, seto.hidetoshi, tglx
Commit-ID: 5c0e9f28da84c68ce0ae68b7a75faaf862e156e2
Gitweb: http://git.kernel.org/tip/5c0e9f28da84c68ce0ae68b7a75faaf862e156e2
Author: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
AuthorDate: Tue, 8 Dec 2009 16:52:44 +0900
Committer: H. Peter Anvin <hpa@zytor.com>
CommitDate: Tue, 8 Dec 2009 12:11:20 -0800
x86, mce: fix confusion between bank attributes and mce attributes
Commit cebe182033f156b430952370fb0f9dbe6e89b081 had an unnecessary,
wrong change: &mce_banks[i].attr is equivalent to the former
bank_attrs[i], not to mce_attrs[i].
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Acked-by: Andi Kleen <andi@firstfloor.org>
LKML-Reference: <4B1E05CC.4040703@jp.fujitsu.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
arch/x86/kernel/cpu/mcheck/mce.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index a96e5cd..a8aacd4 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1929,7 +1929,7 @@ error2:
sysdev_remove_file(&per_cpu(mce_dev, cpu), &mce_banks[j].attr);
error:
while (--i >= 0)
- sysdev_remove_file(&per_cpu(mce_dev, cpu), &mce_banks[i].attr);
+ sysdev_remove_file(&per_cpu(mce_dev, cpu), mce_attrs[i]);
sysdev_unregister(&per_cpu(mce_dev, cpu));
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-08 20:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-08 7:52 [PATCH] x86, mce: fix wrong change in mce_create_device Hidetoshi Seto
2009-12-08 20:12 ` [tip:x86/urgent] x86, mce: fix confusion between bank attributes and mce attributes tip-bot for Hidetoshi Seto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox