From: Jiri Slaby <jirislaby@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
scameron@beardog.cce.hp.com,
James.Bottomley@HansenPartnership.com, achiang@hp.com,
jens.axboe@oracle.com, mikem@beardog.cce.hp.com
Subject: Re: + hpsa-use-msleep-instead-of-schedule_timeout.patch added to -mm tree
Date: Tue, 08 Dec 2009 23:26:25 +0100 [thread overview]
Message-ID: <4B1ED291.60902@gmail.com> (raw)
In-Reply-To: <4B1ED241.4090803@gmail.com>
On 12/08/2009 11:25 PM, Jiri Slaby wrote:
>> @@ -3302,7 +3302,8 @@ static int __devinit hpsa_init_one(struc
>>
>> /* Some devices (notably the HP Smart Array 5i Controller)
>> need a little pause here */
>> - schedule_timeout_uninterruptible(HPSA_POST_RESET_PAUSE);
>> + set_current_state(TASK_UNINTERRUPTIBLE);
>> + msleep(HPSA_POST_RESET_PAUSE_MSECS);
>
> Hmm, setting the state is superfluous, as msleep does the job itself.
(FWIW addressed by Andrew already.)
--
js
next prev parent reply other threads:[~2009-12-08 22:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200912082204.nB8M48oL027313@imap1.linux-foundation.org>
2009-12-08 22:25 ` + hpsa-use-msleep-instead-of-schedule_timeout.patch added to -mm tree Jiri Slaby
2009-12-08 22:26 ` Jiri Slaby [this message]
2009-12-08 22:43 ` scameron
2009-12-08 22:44 ` Andrew Morton
2009-12-09 9:51 ` Jiri Slaby
2009-12-09 15:37 ` scameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1ED291.60902@gmail.com \
--to=jirislaby@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=achiang@hp.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikem@beardog.cce.hp.com \
--cc=mm-commits@vger.kernel.org \
--cc=scameron@beardog.cce.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox