From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Xiao Guangrong <ericxiao.gr@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Paul Mackerras <paulus@samba.org>,
T??r??k Edwin <edwintorok@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] perf/sched: fix for getting task's execution time
Date: Wed, 09 Dec 2009 17:54:41 +0800 [thread overview]
Message-ID: <4B1F73E1.6040000@cn.fujitsu.com> (raw)
In-Reply-To: <4B1F7322.80103@cn.fujitsu.com>
Sorry, miss Reported-by, please ignore this mail, i'll resend it
Xiao Guangrong wrote:
> In current code, task's execute time is got by reading
> '/proc/<pid>/sched' file, it's wrong if the task is created
> by pthread_create(), because every thread task has same pid.
>
> This way also has two demerits:
>
> 1: 'perf sched replay' can't work if the kernel not compile
> with 'CONFIG_SCHED_DEBUG' option
> 2: perf tool should depend on proc file system
>
> So, this patch use PERF_COUNT_SW_TASK_CLOCK to get task's
> execution time instead of reading /proc file
>
> Changelog v2 -> v3:
> use PERF_COUNT_SW_TASK_CLOCK instead of rusage() as Ingo's suggestion
>
> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
next prev parent reply other threads:[~2009-12-09 9:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 10:57 [PATCH] perf/sched: fix for getting task's execute time Xiao Guangrong
2009-12-06 11:05 ` Peter Zijlstra
2009-12-06 11:06 ` Peter Zijlstra
2009-12-06 11:50 ` Ingo Molnar
2009-12-06 17:10 ` Xiao Guangrong
2009-12-07 7:20 ` [PATCH v2] perf/sched: fix for getting task's execution time Xiao Guangrong
2009-12-07 7:30 ` Ingo Molnar
2009-12-09 9:51 ` [PATCH v3] " Xiao Guangrong
2009-12-09 9:54 ` Xiao Guangrong [this message]
2009-12-09 9:59 ` Ingo Molnar
2009-12-09 9:57 ` Xiao Guangrong
2009-12-09 9:57 ` Ingo Molnar
2009-12-09 10:03 ` [tip:perf/urgent] perf sched: Fix " tip-bot for Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1F73E1.6040000@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=edwintorok@gmail.com \
--cc=ericxiao.gr@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox