From: walter harms <wharms@bfs.de>
To: Jan Yenya Kasprzak <kas@fi.muni.cz>
Cc: Rudy Matela <rudy.matela@gmail.com>,
Krzysztof Halasa <khc@pm.waw.pl>,
trivial@kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Coding style correction on some drivers that use Generic HDLC
Date: Wed, 09 Dec 2009 16:43:32 +0100 [thread overview]
Message-ID: <4B1FC5A4.9030300@bfs.de> (raw)
In-Reply-To: <20091209145554.GQ6070@fi.muni.cz>
Jan Yenya Kasprzak schrieb:
> Rudy Matela wrote:
> : Added a space separating some if/switch/while keywords from the following
> : parenthesis to conform to the CodingStyle.
>
> Hello,
>
> I am not sure whether it is necessary to fix formating mistakes in
> a driver which is in deep freeze and the hardware is not produced anymore,
> but whatever.
>
> Acked-By: Jan "Yenya" Kasprzak <kas@fi.muni.cz>
>
> -Yenya
>
> : Signed-off-by: Rudy Matela <rudy.matela@gmail.com>
> : ---
> :
> : drivers/net/wan/cosa.c | 10 +++++-----
> : drivers/net/wan/hdlc_cisco.c | 8 ++++----
> : drivers/net/wan/hdlc_x25.c | 4 ++--
> : 3 files changed, 11 insertions(+), 11 deletions(-)
> :
> : diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
> : index b36bf96..f0bd70f 100644
>
It is ok until the driver is removed, if this "issue" is not fixed it will
trigger any check-coding-style and generate new patches. Since it involves
no code changes it is harmless.
re,
wh
next prev parent reply other threads:[~2009-12-09 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 14:35 [PATCH] Coding style correction on some drivers that use Generic HDLC Rudy Matela
2009-12-09 14:55 ` Jan Yenya Kasprzak
2009-12-09 15:43 ` walter harms [this message]
2009-12-09 21:09 ` Rudy Matela
2009-12-09 23:26 ` Jiri Kosina
2009-12-10 0:40 ` David Miller
2009-12-09 16:41 ` Krzysztof Halasa
2009-12-09 23:24 ` Jiri Kosina
2009-12-10 17:41 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1FC5A4.9030300@bfs.de \
--to=wharms@bfs.de \
--cc=kas@fi.muni.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=rudy.matela@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox