On 12/09/2009 02:17 PM, Alan Jenkins wrote: >> Fixed, this version only calls the enabler if the switch is at ON at >> resume time. > > Ah... I think add() has the same problem as well though? I.e. the > driver will not work if the switch is disabled at load time. > > I would change it in enable() (and then try to think of a new name for > it, maybe try_enable()). Sorta did that, it should do the right thing in all those cases now. Otherwise I am pretty pleased with it now. Unless there's strong objections, I'd say it's good to go. Cheers, Jes