public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: jim owens <jowens@hp.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
	linux-doc@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Dan Carpenter <error27@gmail.com>,
	Jes Sorensen <jes.sorensen@gmail.com>
Subject: Re: [PATCH] Documentation/email-clients.txt: clarify Thunderbird section
Date: Thu, 10 Dec 2009 16:25:22 +0000	[thread overview]
Message-ID: <4B2120F2.3090301@tuffmail.co.uk> (raw)
In-Reply-To: <4B2110E3.8010508@hp.com>

jim owens wrote:
> I don't have a problem with your patch, but it is not true
> that you need to edit the prefs.js to disable line wrap.
>
> I did this in the gui to fix my own patch sending,
> under "Composition" you can set the wrap = 0.
>
> While changing format=flowed does require editing the file,
> on my version of Thunderbird, 2.0.0.23, it isn't clear how
> it breaks the patch to leave it flowed.
>
> And I have never used HTML, Preformat.
>
> jim
>
> Though now that I have said that, Andrew will probably
> tell me the patch I sent is broken ;)
>   

/google

The RFC for format=flowed says that it should escape lines which start 
with a space (by "space stuffing" - prepending an additional space).  So 
in theory it should completely break patches.   And indeed it does 
<http://gcc.gnu.org/ml/java-patches/2003-q2/msg00315.html>

Using HTML preformat in current versions of Thunderbird appears to send 
with a format=flowed content-type, and then violates the RFC by not 
performing any space-stuffing.

So if I look at format=flowed patch in my Sent email folder, I see that 
the message viewer correctly strips the first leading space in each 
line.  I.e. it breaks if you use copy+paste to get the patch out of 
Thunderbird (or any other format=flowed aware client).  File->Save As 
preserves the spaces though, allowing the patch to be applied.

Regards
Alan "Don't you feel better knowing that"

  reply	other threads:[~2009-12-10 16:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-10 14:57 [PATCH] Documentation/email-clients.txt: clarify Thunderbird section Alan Jenkins
2009-12-10 15:16 ` jim owens
2009-12-10 16:25   ` Alan Jenkins [this message]
2009-12-10 16:47     ` jim owens
2009-12-10 22:05     ` Chris Friesen
2009-12-10 22:16       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2120F2.3090301@tuffmail.co.uk \
    --to=alan-jenkins@tuffmail.co.uk \
    --cc=error27@gmail.com \
    --cc=jes.sorensen@gmail.com \
    --cc=jowens@hp.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox