Re: dynamic ftrace - graph

Michal Simek
2009-12-11T14:41:17Z

Steven Rostedt wrote:
> On Fri, 2009-12-11 at 08:29 +0100, Michal Simek wrote:
>> Steven Rostedt wrote:
>>> Hi Michal,
>>>
>>> Sorry for such a late reply, you sent this email to me at the worst
>>> time. My wife was having shoulder surgery and I heading for a
>>> conference. I fell very far behind in email and I only now just noticed
>>> this.
>> No problem. I prepared Microblaze ftrace patches. You can find them in
>> linux-next. I am going to send pull request to Linus soon that's why if
>> you have any your comments please let me know.
>>
>
> Hey, if they work and they are only in your arch, then I'm fine with
> them ;-)

yeah. There is one just small hook to recordmcount.pl. :-)

>
>>>
>>> I'll answer these ever though you may already figured it out.
>>>
>>> On Mon, 2009-11-09 at 17:52 +0100, Michal Simek wrote:
>>>> Hi Steve and others,
>>>>
>>>> I have working dynamic ftrace function. :-)
>>>>
>>>> I look at __ftrace_modify_code function and I have one question about.
>>>> Below are function which are called when I enable function_graph.
>>>>
>>>> I personally think that make more sense to call
>>>> ftrace_enable_ftrace_graph_caller before ftrace_update_ftrace_func.
>>>> The reason for it is that graph_caller enable calling graph tracing
>>>> which should be setup before ftrace_update_ftrace_func which enable
>>>> whole tracing function.
>>> Have you seen any difference in output with this?
>> I haven't tested it. It was just suggestion. I don't know if is relevant
>> or not.
>
> I'm not sure it is relevant. Those are enabled in stop_machine so the
> only thing you would be missing is the tracer enabling itself.

we will see. Currently I have small problem only with irqsoff but I
think this don't have connection with ftrace - only with lockdep I
think. :-)

Thanks,
Michal

>
> -- Steve