Re: [PATCH 2/2] als: tsl2550: Remove spurious check against a maximum lux value.

Jean Delvare
2010-01-27T16:25:51Z

On Wed, 27 Jan 2010 14:53:19 +0000, Jonathan Cameron wrote:
>
> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>

Acked-by: Jean Delvare <khali@linux-fr.org>

> ---
>
> As Jean Delvare observed, this check is ineffective so lets clear it out whilst
> we are working on this driver.
>
> drivers/als/tsl2550.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/als/tsl2550.c b/drivers/als/tsl2550.c
> index b911e9c..27745a5 100644
> --- a/drivers/als/tsl2550.c
> +++ b/drivers/als/tsl2550.c
> @@ -116,8 +116,6 @@ static int tsl2550_get_adc_value(struct i2c_client *client, u8 cmd)
> * of infrared level and visible light levels.
> */
>
> -#define TSL2550_MAX_LUX 1846
> -
> static const u8 ratio_lut[] = {
> 100, 100, 100, 100, 100, 100, 100, 100,
> 100, 100, 100, 100, 100, 100, 99, 99,
> @@ -187,8 +185,7 @@ static int tsl2550_calculate_lux(u8 ch0, u8 ch1)
> else
> return -EAGAIN;
>
> - /* LUX range check */
> - return lux > TSL2550_MAX_LUX ? TSL2550_MAX_LUX : lux;
> + return lux;
> }
>
> /*

--
Jean Delvare